Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 68B67CEBA for ; Tue, 11 Jun 2013 17:27:47 +0000 (UTC) Received: (qmail 91594 invoked by uid 500); 11 Jun 2013 17:27:46 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 91433 invoked by uid 500); 11 Jun 2013 17:27:46 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 91419 invoked by uid 99); 11 Jun 2013 17:27:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jun 2013 17:27:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 964B01CA71D; Tue, 11 Jun 2013 17:27:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1402047780997342325==" MIME-Version: 1.0 Subject: Re: Review Request: Jython for Giraph From: "Nitay Joffe" To: "giraph" , "Nitay Joffe" , "Alessandro Presta" Date: Tue, 11 Jun 2013 17:27:38 -0000 Message-ID: <20130611172738.3558.36084@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nitay Joffe" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/11709/ X-Sender: "Nitay Joffe" References: <20130611171305.3558.98572@reviews.apache.org> In-Reply-To: <20130611171305.3558.98572@reviews.apache.org> Reply-To: "Nitay Joffe" --===============1402047780997342325== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On June 11, 2013, 5:13 p.m., Alessandro Presta wrote: > > Pretty cool! It will be really useful once there is better support for = types: > > 1) some kind of type inference/casting/automatic serialization, so that= one can write setValue(4) instead of setValue(IntWritable(4)) > > 2) possibility to implement all algorithm-related classes (vertex/edge/= message values, aggregators, combiners, etc) directly in Python > > If we could use some Python facility for serializing objects, this woul= d become a really high-level API for writing graph algorithms in Python, wi= thout dealing with Java boilerplate, serialization, etc. Yep those are good ideas. I'll look into these things in other patches. > On June 11, 2013, 5:13 p.m., Alessandro Presta wrote: > > giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.jav= a, line 63 > > > > > > Isn't this a bit redundant? !isPresent seems convenient enough. Als= o, isSet could be a more standard name, yep already removed as per Avery's comment. - Nitay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11709/#review21705 ----------------------------------------------------------- On June 10, 2013, 6:55 a.m., Nitay Joffe wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11709/ > ----------------------------------------------------------- > = > (Updated June 10, 2013, 6:55 a.m.) > = > = > Review request for giraph. > = > = > Description > ------- > = > See JIRA > = > = > This addresses bug GIRAPH-683. > https://issues.apache.org/jira/browse/GIRAPH-683 > = > = > Diffs > ----- > = > giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 = > giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.j= ava 23c614b1112dd455a97b6ee7d32188dc5a5fd574 = > giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark= .java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82 = > giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.jav= a d00f7e908605d8753eb129d0173cf1980034dcc9 = > giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java= c16ec8849641847d53aea8c90dcc0a3fcd646e45 = > giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 4= 1d120b18bdbbf13c8426ec49f8619d273684620 = > giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f= 70d904660f14370c2e5c98cc59b6a48ea18135 = > giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PR= E-CREATION = > giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java f= a21a281525858208b1ee81be1eafa5ddcb22a0f = > giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621= bb14e4962ec9326c3d58b9de33ad83eb23621 = > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.ja= va 58a3f0179d17cd04f2e69789a6e3838cb22d75eb = > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2= d0f59cecfdf580609c9d6373c0878c90cede430 = > giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-C= REATION = > giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraph= Configuration.java aa5249875de551a341a4baac894c68553cbd6e63 = > giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de7= 5e9dc4d1696b11251a8e8cac870f6bbf72230 = > giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0c= bc164756de8a422a8f23f01809200b4d569cbf = > giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a= 583d98820ef946258d2e2a14fc279583b5c5c = > giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 8415= 8df3ded55360af179e08194e14bc43949c77 = > giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.ja= va PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.j= ava PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFac= tory.java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java= 99b28df74232504f2b2a16639473e367f53dd15f = > giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationVali= dator.java de17157dcbeb123fc43184742a59ed1116070dd6 = > giraph-core/src/main/java/org/apache/giraph/jython/Jython.java PRE-CREA= TION = > giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFac= tory.java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PR= E-CREATION = > giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.jav= a a12ef58eec93aa4e801955efcd42f0e5c899275e = > giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.ja= va d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415 = > giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9= f068c4478706e96a726c5caa2f8fda4563 = > giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.= java b4920e1a015eda3ea5d5c381d5b0155f38f1891a = > giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java = 96352bbfc0901e44ffe25bbe2f280a216c797131 = > giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py= PRE-CREATION = > giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-= CREATION = > giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.j= ava PRE-CREATION = > giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py = PRE-CREATION = > giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java = 340b4618ce8fdd4ec2303866b2ded632535e40a4 = > pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b = > = > Diff: https://reviews.apache.org/r/11709/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Nitay Joffe > = > --===============1402047780997342325==--