giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Re: Review Request 12125: GIRAPH-698
Date Thu, 27 Jun 2013 01:27:49 GMT


> On June 27, 2013, 1:01 a.m., Nitay Joffe wrote:
> > giraph-core/src/main/java/org/apache/giraph/master/MasterCompute.java, line 137
> > <https://reviews.apache.org/r/12125/diff/3/?file=312477#file312477line137>
> >
> >     What is this check? Looks odd should be explained

I need the null checks for the master since we don't have the classes set at that time -
which is reasonable, this avoids an NPE.  I think the behavior is reasonable given that the
classes aren't set prior to BspServiceMaster#coordinateSuperstep.


> On June 27, 2013, 1:01 a.m., Nitay Joffe wrote:
> > giraph-core/src/main/java/org/apache/giraph/master/MasterCompute.java, line 159
> > <https://reviews.apache.org/r/12125/diff/3/?file=312477#file312477line159>
> >
> >     As above

Same as above.


- Avery


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12125/#review22456
-----------------------------------------------------------


On June 27, 2013, 12:36 a.m., Avery Ching wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12125/
> -----------------------------------------------------------
> 
> (Updated June 27, 2013, 12:36 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Bugs: GIRAPH-698
>     https://issues.apache.org/jira/browse/GIRAPH-698
> 
> 
> Repository: giraph-git
> 
> 
> Description
> -------
> 
> * Prints out the computation name with the superstep for easier debugging
> * Fixes a minor bug with MasterCompute for differing message types for superstep 0 and
if halted
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/bsp/CentralizedServiceMaster.java f41fc3d54c5a6d4b2e7278afcd030748e3949e98

>   giraph-core/src/main/java/org/apache/giraph/counters/GiraphTimers.java 0d50c29baf1087056c49c08d86313594e0417529

>   giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java 355888785d32d743837056905a16dc2f75a6f035

>   giraph-core/src/main/java/org/apache/giraph/master/MasterCompute.java 310cb26106baa7eec85f16928a6fee66050d08c5

>   giraph-core/src/main/java/org/apache/giraph/master/MasterThread.java e8eeeed61455c471986c72c21023409aa4b8fb6e

>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java 13bb492062a98687a375d36ce3c7c3f2ec8a986e

>   giraph-core/src/test/java/org/apache/giraph/master/TestComputationCombinerTypes.java
8ae09bc13471afc5a7d6e6b548d6110e1edfb4cc 
> 
> Diff: https://reviews.apache.org/r/12125/diff/
> 
> 
> Testing
> -------
> 
> * Ran PageRankBenchmark on a real cluster (output attached to JIRA)
> * mvn clean verify
> 
> 
> Thanks,
> 
> Avery Ching
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message