giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta" <alessan...@fb.com>
Subject Re: Review Request 12125: GIRAPH-698
Date Thu, 27 Jun 2013 00:00:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12125/#review22442
-----------------------------------------------------------



giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java
<https://reviews.apache.org/r/12125/#comment45996>

    You want to avoid checking for previous outgoing message type = incoming message type,
but what about other checks (e.g., combiner message type)? Aren't those valid for superstep
0 too?


- Alessandro Presta


On June 26, 2013, 11:48 p.m., Avery Ching wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12125/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 11:48 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Bugs: GIRAPH-698
>     https://issues.apache.org/jira/browse/GIRAPH-698
> 
> 
> Repository: giraph-git
> 
> 
> Description
> -------
> 
> * Prints out the computation name with the superstep for easier debugging
> * Fixes a minor bug with MasterCompute for differing message types for superstep 0 and
if halted
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/bsp/CentralizedServiceMaster.java f41fc3d54c5a6d4b2e7278afcd030748e3949e98

>   giraph-core/src/main/java/org/apache/giraph/counters/GiraphTimers.java 0d50c29baf1087056c49c08d86313594e0417529

>   giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java 355888785d32d743837056905a16dc2f75a6f035

>   giraph-core/src/main/java/org/apache/giraph/master/MasterCompute.java 310cb26106baa7eec85f16928a6fee66050d08c5

>   giraph-core/src/main/java/org/apache/giraph/master/MasterThread.java e8eeeed61455c471986c72c21023409aa4b8fb6e

> 
> Diff: https://reviews.apache.org/r/12125/diff/
> 
> 
> Testing
> -------
> 
> * Ran PageRankBenchmark on a real cluster (output attached to JIRA)
> * mvn clean verify
> 
> 
> Thanks,
> 
> Avery Ching
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message