giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe" <ni...@apache.org>
Subject Re: Review Request 12080: GIRAPH-693: Giraph-Hive check user code as soon as possible
Date Wed, 26 Jun 2013 03:42:45 GMT


> On June 26, 2013, 3:35 a.m., Avery Ching wrote:
> > This looks like a reasonable solution unless we come up with something better. 
One question though.  Will applications downstream fail if they were relying on not having
an edge value column name set in Hive?  We should be careful about that when pulling in this
change.
> > 
> > One minor comment below.
> 
> Avery Ching wrote:
>     Oh, and +1.

Not sure what you mean about the edge value column name, can you point me to the potentially
problematic code you're referring to?


- Nitay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12080/#review22383
-----------------------------------------------------------


On June 25, 2013, 4:10 p.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12080/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 4:10 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Bugs: GIRAPH-693
>     https://issues.apache.org/jira/browse/GIRAPH-693
> 
> 
> Repository: giraph-git
> 
> 
> Description
> -------
> 
> GIRAPH-693
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 435dd879beb2ce4e3cfd4ed7c5f5922c7c4892b0

>   giraph-core/src/main/java/org/apache/giraph/io/GiraphInputFormat.java 86e86d8c8a4a7a405ea90dc1e979657b9d0e83ff

>   giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedEdgeInputFormat.java
9c209dd7af43450c0dc1f5dc7859768f7b91e79b 
>   giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexInputFormat.java
f5379c1039951ea7809d574585068933e8ea1616 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 9fe76635a42cddf1d485af8565628f97cb993950

>   giraph-hive/src/main/java/org/apache/giraph/hive/common/HiveInputOptions.java 5108730ab454d21489629358e85ea2cfcf941327

>   giraph-hive/src/main/java/org/apache/giraph/hive/common/HiveParsing.java bd283967ad0312c6125061e43f196a27dca5b8da

>   giraph-hive/src/main/java/org/apache/giraph/hive/common/HiveUtils.java 2d2fc1edd65304afdd3338cb29ef64f297774c0f

>   giraph-hive/src/main/java/org/apache/giraph/hive/input/HiveInputChecker.java PRE-CREATION

>   giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeInputFormat.java
a0e9cf3e5366d3cf2b639cb08e4e9d32d0fd14f1 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeReader.java a010307b14dc02d0b8cc804d916025f3df3bcf9a

>   giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveToEdge.java 61b56d14a7caf11da6a396c96217ffcee81863e3

>   giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/examples/HiveIntDoubleEdge.java
76cf7e01b51724a96ca672ed9db22d5328553168 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/examples/HiveIntNullEdge.java
3de96800704c809dbe97003f3a305cdc9ce3e903 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveToVertex.java a9736c69162e5d4a0a297cdea93b3e8186cdde5a

>   giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveVertexInputFormat.java
063c472b7da9fb15ddf1f64324ff5f62a68a32ad 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveVertexReader.java
db61afff4fffe03c90ed100da2edf5ee28c98c4e 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/examples/HiveIntDoubleDoubleVertex.java
ea2f4191f807596c2cbd3aaed5e248224a1a85cc 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/examples/HiveIntNullNullVertex.java
4e32039746ebb2c95404deffb16b845f6004a5d0 
>   giraph-hive/src/main/java/org/apache/giraph/hive/output/HiveVertexOutputFormat.java
6968eef3909fdf1dbed02edc619c63cfc572c732 
>   giraph-hive/src/main/java/org/apache/giraph/hive/output/HiveVertexWriter.java 352dee3230cdf8a5dc8b75f5ea60c0ecfcb5ba14

>   giraph-hive/src/main/java/org/apache/giraph/hive/output/SimpleVertexToHive.java c3fb6b61d50b5ea205a513c5e2e283f7de06d472

>   giraph-hive/src/main/java/org/apache/giraph/hive/output/VertexToHive.java 28f987e4db7d7457e043359b52e09481b1edef83

>   giraph-hive/src/main/java/org/apache/giraph/hive/output/examples/HiveOutputIntIntVertex.java
975d03d41fbe9097b1761c02417c0b8cd8b9939f 
>   giraph-hive/src/test/java/org/apache/giraph/hive/Helpers.java 1103f78bda62ad5ffb6a31c13a54ee0dde661fcb

>   giraph-hive/src/test/java/org/apache/giraph/hive/input/CheckInputTest.java PRE-CREATION

>   giraph-hive/src/test/java/org/apache/giraph/hive/input/HiveEdgeInputTest.java 0bb083c81532ef4e79388351c349dad27182063d

>   giraph-hive/src/test/java/org/apache/giraph/hive/input/HiveVertexInputTest.java ec2b7b12a2148b285db42d13dbe82c470d3fee62

>   giraph-hive/src/test/java/org/apache/giraph/hive/output/CheckOutputTest.java PRE-CREATION

>   giraph-hive/src/test/java/org/apache/giraph/hive/output/HiveOutputTest.java 43e853be881bbc72d135d6a598f6aeb9d6a66c74

>   pom.xml 7e166c420534b8d395fcff876f80c81bc08255f0 
> 
> Diff: https://reviews.apache.org/r/12080/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message