giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching" <avery.ch...@gmail.com>
Subject Re: Review Request: Jython for Computation
Date Wed, 19 Jun 2013 00:09:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/#review22023
-----------------------------------------------------------


These are mostly minor comments (mostly grammar and formatting).  

Can you please add a two sentence use guide to the website or to the README?

Once you submit a revision with the fixes, I'll do a quick pass and let's get this in!


giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java
<https://reviews.apache.org/r/11709/#comment45457>

    Can we indicate if this is a local path or HDFS path?



giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
<https://reviews.apache.org/r/11709/#comment45458>

    to decide...what to return?



giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
<https://reviews.apache.org/r/11709/#comment45459>

    Name



giraph-core/src/main/java/org/apache/giraph/graph/Computation.java
<https://reviews.apache.org/r/11709/#comment45338>

    giraph.computation.language should be a constant.



giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java
<https://reviews.apache.org/r/11709/#comment45460>

    @Override should be on a separate line.



giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java
<https://reviews.apache.org/r/11709/#comment45461>

    I am a little confused why we need to do this.



giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java
<https://reviews.apache.org/r/11709/#comment45462>

    initComputation: Jython...



giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java
<https://reviews.apache.org/r/11709/#comment45463>

    getPythonScriptStream: Reading...
    Missing if wrapper.



giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java
<https://reviews.apache.org/r/11709/#comment45465>

    Can you please add the method name to the exception message?



giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java
<https://reviews.apache.org/r/11709/#comment45464>

    getPythonScriptStream: Reading...
    Missing if wrapper.



giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java
<https://reviews.apache.org/r/11709/#comment45467>

    This isn't thread-safe, but it's a global variable.  Let's at least make it volatile (if
semantically it makes sense) if not thread-safe.



giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java
<https://reviews.apache.org/r/11709/#comment45469>

    Can we check for the Jython case specificaly?  conf should know?



giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java
<https://reviews.apache.org/r/11709/#comment45472>

    You probably didn't have to change this to array from list (You could have changed the
return to an ArrayList), but it's okay.



giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java
<https://reviews.apache.org/r/11709/#comment45475>

    method prefix.



giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java
<https://reviews.apache.org/r/11709/#comment45476>

    missing line.


- Avery Ching


On June 13, 2013, 5:29 p.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11709/
> -----------------------------------------------------------
> 
> (Updated June 13, 2013, 5:29 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> This addresses bug GIRAPH-683.
>     https://issues.apache.org/jira/browse/GIRAPH-683
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 50d411a9fc6a5ba98726ad1236f532cfe6cd1a29 
>   giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574

>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82

>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9

>   giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java 5d150d02b5ba85b7fce23d6494c847e986a3d391

>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45

>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620

>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135

>   giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
dbd24523d256f7cddb3667980f8a0949d4491a5c 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230

>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf

>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c

>   giraph-core/src/main/java/org/apache/giraph/conf/TypesHolder.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77

>   giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f

>   giraph-core/src/main/java/org/apache/giraph/graph/Language.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/IntIntNullTextInputFormat.java
91725f83e2c1f18fb8a250ea49261d32ea518188 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/LongLongNullTextInputFormat.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6

>   giraph-core/src/main/java/org/apache/giraph/jython/DeployType.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e

>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415

>   giraph-core/src/main/java/org/apache/giraph/utils/DistributedCacheUtils.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563

>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a

>   giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131

>   giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION

>   giraph-core/src/test/java/org/apache/giraph/BspCase.java 137cb6ea59ffd2d7b489cf4255b6b172c840bef0

>   giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION

>   giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION

>   giraph-examples/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java
13e8edfed9f36bd20659bdcec40d4378947292df 
>   giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 6c8a0b39383dfd10c37ef63b0b56c1ecf7cc19bc

>   giraph-examples/src/test/java/org/apache/giraph/TestComputationState.java 1092eac7e2c35e9cc76c6a32c48d74515bf01953

>   giraph-examples/src/test/java/org/apache/giraph/TestGraphPartitioner.java 4537eacc186d6f2b1d94ee543614a1533fbdd1b2

>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4

>   pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 
> 
> Diff: https://reviews.apache.org/r/11709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message