giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe" <ni...@apache.org>
Subject Re: Review Request: review updates
Date Tue, 11 Jun 2013 17:29:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11709/
-----------------------------------------------------------

(Updated June 11, 2013, 5:29 p.m.)


Review request for giraph.


Changes
-------

Avery and Alessandro's comments


Description
-------

See JIRA


This addresses bug GIRAPH-683.
    https://issues.apache.org/jira/browse/GIRAPH-683


Diffs (updated)
-----

  CHANGELOG fe0c8fdc6d73520318cd531755a6af25b0ba7b84 
  giraph-accumulo/src/test/java/org/apache/giraph/io/accumulo/edgemarker/AccumuloEdgeInputFormat.java
108ae61d5e57ba293a414028e1cb8b8c685b150c 
  giraph-core/pom.xml 3ffe175b675d5be1d878d83d37a04935d30130d6 
  giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 23c614b1112dd455a97b6ee7d32188dc5a5fd574

  giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java bd2939ec4ce9d3fa373fda667e75df7e0da1cc82

  giraph-core/src/main/java/org/apache/giraph/comm/SendMutationsCache.java 9348e61cd83985d920d3ed825d0fbdb3f3ab9fff

  giraph-core/src/main/java/org/apache/giraph/comm/SendPartitionCache.java 68ce0955d8088ed87a6599fd5cd144cd7e470e6c

  giraph-core/src/main/java/org/apache/giraph/comm/WorkerClientRequestProcessor.java 731d0eee0123ea9b5cecc47cff18d6be174f3e47

  giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
06965ca488aceb593a249a7c88bd49d660080c20 
  giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java d00f7e908605d8753eb129d0173cf1980034dcc9

  giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java 5d150d02b5ba85b7fce23d6494c847e986a3d391

  giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java c16ec8849641847d53aea8c90dcc0a3fcd646e45

  giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java 41d120b18bdbbf13c8426ec49f8619d273684620

  giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java 8f70d904660f14370c2e5c98cc59b6a48ea18135

  giraph-core/src/main/java/org/apache/giraph/conf/EnumConfOption.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java fa21a281525858208b1ee81be1eafa5ddcb22a0f

  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 621bb14e4962ec9326c3d58b9de33ad83eb23621

  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 58a3f0179d17cd04f2e69789a6e3838cb22d75eb

  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 2d0f59cecfdf580609c9d6373c0878c90cede430

  giraph-core/src/main/java/org/apache/giraph/conf/GiraphTypes.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
aa5249875de551a341a4baac894c68553cbd6e63 
  giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java de75e9dc4d1696b11251a8e8cac870f6bbf72230

  giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java 0cbc164756de8a422a8f23f01809200b4d569cbf

  giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java 83a583d98820ef946258d2e2a14fc279583b5c5c

  giraph-core/src/main/java/org/apache/giraph/edge/EdgeStore.java 420bf9353871540594309ee9b4c129ae91ea7680

  giraph-core/src/main/java/org/apache/giraph/edge/LongNullHashSetEdges.java 139fc7afb75aac92488e4aec7da3ff8bfbcd540c

  giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77

  giraph-core/src/main/java/org/apache/giraph/graph/ComputationFactory.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputationLanguage.java PRE-CREATION

  giraph-core/src/main/java/org/apache/giraph/graph/DefaultComputationFactory.java PRE-CREATION

  giraph-core/src/main/java/org/apache/giraph/graph/DefaultVertex.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 99b28df74232504f2b2a16639473e367f53dd15f

  giraph-core/src/main/java/org/apache/giraph/graph/Vertex.java 1241ae757b29cb7bec80fd3bb3d2bab1ac9c21bd

  giraph-core/src/main/java/org/apache/giraph/graph/VertexMutations.java 6f54dc701a5f5dc4589140dfb4a6d0dc5f128dca

  giraph-core/src/main/java/org/apache/giraph/io/VertexReader.java 9695169b5ccf8325987e42de90e7cd3011c0b901

  giraph-core/src/main/java/org/apache/giraph/io/VertexValueReader.java 70e721ec8e4a120a094206e5b857b9bb75eb7acd

  giraph-core/src/main/java/org/apache/giraph/io/formats/GraphvizOutputFormat.java PRE-CREATION

  giraph-core/src/main/java/org/apache/giraph/io/formats/JsonLongDoubleFloatDoubleVertexInputFormat.java
112860c12d203b734093973c3b5d9dd6db39b14a 
  giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomVertexInputFormat.java
91a19e6484631e4334b6c3843ba7aedfec169276 
  giraph-core/src/main/java/org/apache/giraph/io/formats/SequenceFileVertexInputFormat.java
1d31f4fb7a688ce314be5608f88726daa9152833 
  giraph-core/src/main/java/org/apache/giraph/io/formats/TextVertexInputFormat.java debdcccaf96cf105b5c0b3a73515f82860913178

  giraph-core/src/main/java/org/apache/giraph/io/iterables/VertexReaderWrapper.java ca35c517666910e613431a3641f48f8df223f8b4

  giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java de17157dcbeb123fc43184742a59ed1116070dd6

  giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java PRE-CREATION

  giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/jython/package-info.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java a12ef58eec93aa4e801955efcd42f0e5c899275e

  giraph-core/src/main/java/org/apache/giraph/partition/DiskBackedPartitionStore.java dadce0f14fe4ecac1dd35c35adf593a63e9583d9

  giraph-core/src/main/java/org/apache/giraph/partition/Partition.java aebd34344b10cb3752c74c27f62bf3cfa5d3d565

  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java d8b121b14c93cd8b2c0664ab23c2af6d3c5b6415

  giraph-core/src/main/java/org/apache/giraph/utils/FileUtils.java 442fc9f068c4478706e96a726c5caa2f8fda4563

  giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInputFormat.java 6ca488cb42efec02b49f1ec9b4d22ec0b40bca42

  giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java b4920e1a015eda3ea5d5c381d5b0155f38f1891a

  giraph-core/src/main/java/org/apache/giraph/utils/ReflectionUtils.java 96352bbfc0901e44ffe25bbe2f280a216c797131

  giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java 6e46a76b656543c97a6b0c5eaad848633bd48bb6

  giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 8b5e39a021adc733ff6fc1ef62d6aea6abd61256

  giraph-core/src/main/resources/org/apache/giraph/benchmark/page-rank.py PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/graph/TestVertexAndEdges.java d0a6c46114b5d2b42a5fcdba93e293d404e4257f

  giraph-core/src/test/java/org/apache/giraph/io/TestAdjacencyListTextVertexOutputFormat.java
fdfb5e91dc692283a67f7fcaf309e8387f75a36d 
  giraph-core/src/test/java/org/apache/giraph/io/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java
c67a1c44eed7b35a3c872d2032bc4e5ae77e7ef7 
  giraph-core/src/test/java/org/apache/giraph/io/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java
80340528326d9b37a380d9a761115b28b879ce2d 
  giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/partition/TestGiraphTransferRegulator.java 8a1e9edaea53476d50dd90d70afc80c76d7f090a

  giraph-core/src/test/java/org/apache/giraph/partition/TestPartitionStores.java 45542b9083f8821ee664487791a7b6a50c115c8e

  giraph-core/src/test/java/org/apache/giraph/utils/MockUtils.java d210928374b21e42bac960c2d191386df42c119e

  giraph-core/src/test/java/org/apache/giraph/utils/TestReflectionUtils.java PRE-CREATION

  giraph-core/src/test/resources/org/apache/giraph/jython/count-edges.py PRE-CREATION 
  giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleDoubleTextInputFormat.java
f56b4f6a4c3f26e521829b5da4718ed8bc4e7b64 
  giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleNullTextInputFormat.java
bfb5f40bd2e7b8da321b5b818e377fea16fccecd 
  giraph-examples/src/main/java/org/apache/giraph/examples/NormalizingLongDoubleDoubleTextInputFormat.java
5023a4e2ca80cf6fe0afe83598c11b00308fc630 
  giraph-examples/src/main/java/org/apache/giraph/examples/SimplePageRankComputation.java
d053bb3ceb0c77a3a6dbe46ffa330e9d5f8d035c 
  giraph-examples/src/main/java/org/apache/giraph/examples/SimpleSuperstepComputation.java
c3fd215b29a445b540a39b99f39cd7eaee195c91 
  giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 28edbba58a0513a2fe0b051e02e723dfd283de20

  giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsComputationTestInMemory.java
b94f8dcbd961d24f341cff252512c3a102b37ddb 
  giraph-examples/src/test/java/org/apache/giraph/examples/SimpleShortestPathsComputationTest.java
93a3248f7fd5a94a84c8daf7c277ca954c859071 
  giraph-examples/src/test/java/org/apache/giraph/examples/SimpleTriangleClosingComputationTest.java
73516a473ffd500500aeba083889ca3e5b7c3f03 
  giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeInputFormat.java
1af46d1d6f9e2add4eb25ecdf1e5b351b5bf9132 
  giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeOutputFormat.java
a04d3864334158781b051e29fa8d02e3eba2b630 
  giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexInputFormat.java
53c7eed811e326980f8adf4a34ba41a4152b5416 
  giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 340b4618ce8fdd4ec2303866b2ded632535e40a4

  pom.xml 0bd85a45f2b26d34c0eacd2ecd7068fefccbb91b 

Diff: https://reviews.apache.org/r/11709/diff/


Testing
-------


Thanks,

Nitay Joffe


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message