giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe" <ni...@apache.org>
Subject Re: Review Request: GIRAPH-468: Make Vertex an Interface (nitay)
Date Fri, 07 Jun 2013 10:27:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11682/#review21566
-----------------------------------------------------------



giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
<https://reviews.apache.org/r/11682/#comment44614>

    Note I optimized this. There's no reason to use reflection and newInstance() when we know
what the Vertex class will be.


- Nitay Joffe


On June 6, 2013, 7:20 p.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11682/
> -----------------------------------------------------------
> 
> (Updated June 6, 2013, 7:20 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> Vertex interface
> 
> 
> Diffs
> -----
> 
>   giraph-accumulo/src/test/java/org/apache/giraph/io/accumulo/edgemarker/AccumuloEdgeInputFormat.java
108ae61d5e57ba293a414028e1cb8b8c685b150c 
>   giraph-core/src/main/java/org/apache/giraph/comm/SendMutationsCache.java 9348e61cd83985d920d3ed825d0fbdb3f3ab9fff

>   giraph-core/src/main/java/org/apache/giraph/comm/SendPartitionCache.java 68ce0955d8088ed87a6599fd5cd144cd7e470e6c

>   giraph-core/src/main/java/org/apache/giraph/comm/WorkerClientRequestProcessor.java
731d0eee0123ea9b5cecc47cff18d6be174f3e47 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
06965ca488aceb593a249a7c88bd49d660080c20 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerServer.java b45703853a6e5c57a5854cc40036912a20c59293

>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
aa5249875de551a341a4baac894c68553cbd6e63 
>   giraph-core/src/main/java/org/apache/giraph/edge/EdgeStore.java 420bf9353871540594309ee9b4c129ae91ea7680

>   giraph-core/src/main/java/org/apache/giraph/graph/BasicVertex.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/Computation.java 84158df3ded55360af179e08194e14bc43949c77

>   giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java 6fdcfb05b102a78744d84bcba4e8dc8c30a3e25c

>   giraph-core/src/main/java/org/apache/giraph/graph/DefaultVertexResolver.java 748c3a6a2b84dc07d17bd453c1d3b680da24da26

>   giraph-core/src/main/java/org/apache/giraph/graph/IOVertex.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/Vertex.java 1241ae757b29cb7bec80fd3bb3d2bab1ac9c21bd

>   giraph-core/src/main/java/org/apache/giraph/graph/VertexChanges.java 3d09c06b43d2bd54d3c1ee70d2e4d6c9d3396207

>   giraph-core/src/main/java/org/apache/giraph/graph/VertexMutations.java 6f54dc701a5f5dc4589140dfb4a6d0dc5f128dca

>   giraph-core/src/main/java/org/apache/giraph/graph/VertexResolver.java b6659f47c6b6ce33efd0295487d34b0e2a0a3ffc

>   giraph-core/src/main/java/org/apache/giraph/io/VertexReader.java 9695169b5ccf8325987e42de90e7cd3011c0b901

>   giraph-core/src/main/java/org/apache/giraph/io/VertexValueReader.java 70e721ec8e4a120a094206e5b857b9bb75eb7acd

>   giraph-core/src/main/java/org/apache/giraph/io/formats/JsonLongDoubleFloatDoubleVertexInputFormat.java
112860c12d203b734093973c3b5d9dd6db39b14a 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomIntNullVertexInputFormat.java
d8abfdb063d745c736fe6c7559e8c709ed6fd115 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomVertexInputFormat.java
91a19e6484631e4334b6c3843ba7aedfec169276 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/SequenceFileVertexInputFormat.java
1d31f4fb7a688ce314be5608f88726daa9152833 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/TextVertexInputFormat.java debdcccaf96cf105b5c0b3a73515f82860913178

>   giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexReader.java 54adfec054fb53abf9245fb458c9f456ad5f3e6f

>   giraph-core/src/main/java/org/apache/giraph/io/iterables/VertexReaderWrapper.java ca35c517666910e613431a3641f48f8df223f8b4

>   giraph-core/src/main/java/org/apache/giraph/partition/ByteArrayPartition.java 6eaa6d76efac80c53251ad1037f1c44ed6c4d933

>   giraph-core/src/main/java/org/apache/giraph/partition/DiskBackedPartitionStore.java
dadce0f14fe4ecac1dd35c35adf593a63e9583d9 
>   giraph-core/src/main/java/org/apache/giraph/partition/Partition.java aebd34344b10cb3752c74c27f62bf3cfa5d3d565

>   giraph-core/src/main/java/org/apache/giraph/partition/SimplePartition.java 0c1b40439a8891629b60aace4d89997ade42d1b5

>   giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInputFormat.java 6ca488cb42efec02b49f1ec9b4d22ec0b40bca42

>   giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java 6e46a76b656543c97a6b0c5eaad848633bd48bb6

>   giraph-core/src/main/java/org/apache/giraph/utils/WritableUtils.java c78d717fd1f1e91d2c07c6455ae671fba6516e82

>   giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallable.java 977e1000c33fd50c3074d535076772ad6ff1c746

>   giraph-core/src/test/java/org/apache/giraph/comm/RequestTest.java 70165729d5230a2620465ffbc69affc1896e1431

>   giraph-core/src/test/java/org/apache/giraph/graph/TestVertexAndEdges.java d0a6c46114b5d2b42a5fcdba93e293d404e4257f

>   giraph-core/src/test/java/org/apache/giraph/io/TestAdjacencyListTextVertexOutputFormat.java
fdfb5e91dc692283a67f7fcaf309e8387f75a36d 
>   giraph-core/src/test/java/org/apache/giraph/io/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java
c67a1c44eed7b35a3c872d2032bc4e5ae77e7ef7 
>   giraph-core/src/test/java/org/apache/giraph/io/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java
80340528326d9b37a380d9a761115b28b879ce2d 
>   giraph-core/src/test/java/org/apache/giraph/partition/TestGiraphTransferRegulator.java
8a1e9edaea53476d50dd90d70afc80c76d7f090a 
>   giraph-core/src/test/java/org/apache/giraph/partition/TestPartitionStores.java 45542b9083f8821ee664487791a7b6a50c115c8e

>   giraph-core/src/test/java/org/apache/giraph/utils/MockUtils.java d210928374b21e42bac960c2d191386df42c119e

>   giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleDoubleTextInputFormat.java
f56b4f6a4c3f26e521829b5da4718ed8bc4e7b64 
>   giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleNullTextInputFormat.java
bfb5f40bd2e7b8da321b5b818e377fea16fccecd 
>   giraph-examples/src/main/java/org/apache/giraph/examples/NormalizingLongDoubleDoubleTextInputFormat.java
5023a4e2ca80cf6fe0afe83598c11b00308fc630 
>   giraph-examples/src/main/java/org/apache/giraph/examples/SimplePageRankComputation.java
d053bb3ceb0c77a3a6dbe46ffa330e9d5f8d035c 
>   giraph-examples/src/main/java/org/apache/giraph/examples/SimpleSuperstepComputation.java
c3fd215b29a445b540a39b99f39cd7eaee195c91 
>   giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 28edbba58a0513a2fe0b051e02e723dfd283de20

>   giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsComputationTestInMemory.java
b94f8dcbd961d24f341cff252512c3a102b37ddb 
>   giraph-examples/src/test/java/org/apache/giraph/examples/SimpleShortestPathsComputationTest.java
93a3248f7fd5a94a84c8daf7c277ca954c859071 
>   giraph-examples/src/test/java/org/apache/giraph/examples/SimpleTriangleClosingComputationTest.java
73516a473ffd500500aeba083889ca3e5b7c3f03 
>   giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeInputFormat.java
1af46d1d6f9e2add4eb25ecdf1e5b351b5bf9132 
>   giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeOutputFormat.java
a04d3864334158781b051e29fa8d02e3eba2b630 
>   giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexInputFormat.java
53c7eed811e326980f8adf4a34ba41a4152b5416 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveToVertex.java a9736c69162e5d4a0a297cdea93b3e8186cdde5a

>   giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveVertexReader.java
db61afff4fffe03c90ed100da2edf5ee28c98c4e 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/SimpleHiveToVertex.java
5483a6826d945a13a95dbd42eb8fa3e3aaeb2e97 
> 
> Diff: https://reviews.apache.org/r/11682/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message