Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 77D35D539 for ; Fri, 17 May 2013 17:19:16 +0000 (UTC) Received: (qmail 69299 invoked by uid 500); 17 May 2013 17:19:16 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 69248 invoked by uid 500); 17 May 2013 17:19:16 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 69231 invoked by uid 500); 17 May 2013 17:19:16 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Received: (qmail 69227 invoked by uid 99); 17 May 2013 17:19:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 May 2013 17:19:16 +0000 Date: Fri, 17 May 2013 17:19:16 +0000 (UTC) From: "Alessandro Presta (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (GIRAPH-668) GiraphConfigurationValidator is broken MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Alessandro Presta created GIRAPH-668: ---------------------------------------- Summary: GiraphConfigurationValidator is broken Key: GIRAPH-668 URL: https://issues.apache.org/jira/browse/GIRAPH-668 Project: Giraph Issue Type: Bug Reporter: Alessandro Presta GiraphConfigurationValidator is supposed to compare the I, V, E, M parameters across all user-specified classes, and signal mismatches. Unfortunately, there are a few issues that make it more of a hassle than a help: 1) ReflectionUtils, which is used to extract type information, doesn't work when the base is an interface instead of an abstract class (this is a problem with VertexValueFactory and OutEdges, see for example https://issues.apache.org/jira/browse/GIRAPH-644?focusedCommentId=13640687&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13640687) 2) In at least one case (VertexValueInputFormat), we specialize one argument to Writable. This will always give a mismatch with the actual type specified in the Vertex. In those cases, we should bypass checking that argument. Ideally we should fix all these issues and also make sure GiraphConfigurationValidator is called for any job (not only when using GiraphRunner). If this can't be easily done, we should at least (partially) disable the checks so that we don't fail jobs that have nothing wrong. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira