giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo" <majakabi...@fb.com>
Subject Re: Review Request: GIRAPH-560: input filtering
Date Mon, 06 May 2013 20:17:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10937/#review20219
-----------------------------------------------------------

Ship it!


Looks good.
For consistency, please use 'vertices' instead of 'vertexes'.


giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallable.java
<https://reviews.apache.org/r/10937/#comment41465>

    Add the leftover in inputSplitVerticesFiltered in the end?


- Maja Kabiljo


On May 3, 2013, 10:03 p.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10937/
> -----------------------------------------------------------
> 
> (Updated May 3, 2013, 10:03 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> GIRAPH-560: input filtering
> 
> 
> This addresses bug GIRAPH-560.
>     https://issues.apache.org/jira/browse/GIRAPH-560
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 7c906d292fbbe314cac3c73da597bc50e5a350fc 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 4a0e8f78efce3cfd13687e6fe720cbe18e16a5dc

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java deb2069acfcd60016f42ecdeffbbad7742dd1066

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 6a5949e049c0f674369a01891540a63eaf9a378c

>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
f5a926f3c354e6cda235396254cb7d667de3496d 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 97cf55de2aa33e1009f4a9acdb6fb3f74ba3481f

>   giraph-core/src/main/java/org/apache/giraph/io/filters/DefaultEdgeInputFilter.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/filters/DefaultVertexInputFilter.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/filters/EdgeInputFilter.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/io/filters/VertexInputFilter.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/io/filters/package-info.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/metrics/MetricNames.java 52a3d15f368398bb31652f826e488d47462d4a9d

>   giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 01937abc7aa54a51c6dbaefcb881101d3d334f5f

>   giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallable.java de1e774df8af0568fb44719fb968f74d81797cba

>   giraph-core/src/main/java/org/apache/giraph/worker/InputSplitsCallable.java a3a9ab7754b1a41b29b45c87be1331e2cf949975

>   giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallable.java 224856e14709b103b4618c956cf49413fb8caee2

>   giraph-core/src/test/java/org/apache/giraph/io/TestEdgeInput.java 07d4cc88a3d466d44886a4916ca1fd8a1dea65e1

>   giraph-core/src/test/java/org/apache/giraph/io/TestFilters.java PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/vertexes/IntIntNullVertexDoNothing.java
PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/vertexes/VertexCountEdges.java PRE-CREATION

>   giraph-core/src/test/java/org/apache/giraph/vertexes/VertexDoNothing.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/10937/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message