giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe" <ni...@apache.org>
Subject Re: Review Request: giraph-hive tests
Date Thu, 02 May 2013 04:55:43 GMT


> On May 1, 2013, 7:12 p.m., Maja Kabiljo wrote:
> > giraph-hive/src/test/java/org/apache/giraph/hive/output/HiveOutputTest.java, lines
108-118
> > <https://reviews.apache.org/r/10865/diff/1/?file=286255#file286255line108>
> >
> >     We can't guarantee the order, right?


- Nitay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10865/#review20018
-----------------------------------------------------------


On April 30, 2013, 7:11 p.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10865/
> -----------------------------------------------------------
> 
> (Updated April 30, 2013, 7:11 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> Add tests to giraph-hive
> 
> 
> This addresses bug GIRAPH-651.
>     https://issues.apache.org/jira/browse/GIRAPH-651
> 
> 
> Diffs
> -----
> 
>   .gitignore 0b7eb2ece2caefba49e9f479278af46c1d3963c4 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 029cb5dcd0b9f937fe3033477e65c2cca2798c29

>   giraph-hcatalog/pom.xml 03b86b5b47dd815c85bf3cb4b2590381f9061401 
>   giraph-hive/pom.xml c2d46e98a3f249e1666795b24424dda77d92baf9 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 8d67c1df4e668bcdfb93b1e6b153910b957d55bc

>   giraph-hive/src/main/java/org/apache/giraph/hive/common/GiraphHiveConstants.java 49e1bb58fc493e4504d8d9b7d8c15b0747056eec

>   giraph-hive/src/main/java/org/apache/giraph/hive/common/HiveInputOptions.java PRE-CREATION

>   giraph-hive/src/main/java/org/apache/giraph/hive/common/HiveUtils.java a8c88f56769c7dc2b77ccd231351895e659943f7

>   giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeInputFormat.java
bdae1dd743cafce64efce18affd0a1999905cc09 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeReader.java 2891a171cefe8ced5b90b51370872b5b46d67594

>   giraph-hive/src/main/java/org/apache/giraph/hive/input/examples/HiveIntNullEdge.java
PRE-CREATION 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/examples/HiveIntNullNullVertex.java
PRE-CREATION 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/examples/package-info.java PRE-CREATION

>   giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveVertexInputFormat.java
55500cb957eb6e8c84488cd07069f87cda16405d 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveVertexReader.java
d5e352dac24fb93d1068ed698cc7b60d81c3ed7a 
>   giraph-hive/src/main/java/org/apache/giraph/hive/output/examples/HiveOutputIntIntVertex.java
PRE-CREATION 
>   giraph-hive/src/main/java/org/apache/giraph/hive/output/examples/package-info.java
PRE-CREATION 
>   giraph-hive/src/test/java/org/apache/giraph/hive/Helpers.java PRE-CREATION 
>   giraph-hive/src/test/java/org/apache/giraph/hive/input/HiveEdgeInputTest.java PRE-CREATION

>   giraph-hive/src/test/java/org/apache/giraph/hive/input/HiveVertexInputTest.java PRE-CREATION

>   giraph-hive/src/test/java/org/apache/giraph/hive/input/package-info.java PRE-CREATION

>   giraph-hive/src/test/java/org/apache/giraph/hive/output/HiveOutputTest.java PRE-CREATION

>   giraph-hive/src/test/java/org/apache/giraph/hive/output/package-info.java PRE-CREATION

>   giraph-hive/src/test/java/org/apache/giraph/hive/vertexes/VertexCountEdges.java PRE-CREATION

>   giraph-hive/src/test/java/org/apache/giraph/hive/vertexes/package-info.java PRE-CREATION

>   pom.xml 6d2bdd1cf2399db119ab50e3dfb7a825b2930691 
> 
> Diff: https://reviews.apache.org/r/10865/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message