Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@giraph.apache.org
Date: Thu, 4 Apr 2013 12:01:19 +0000 (UTC)
From: "Nitay Joffe (JIRA)" <jira@apache.org>
To: giraph-dev@incubator.apache.org
Message-ID: <JIRA.12633848.1361773542880.106433.1365076879262@arcas>
In-Reply-To: <JIRA.12633848.1361773542880@arcas>
References: <JIRA.12633848.1361773542880@arcas>
Subject: [jira] [Commented] (GIRAPH-536) Clean up configuration options
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/GIRAPH-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622066#comment-13622066 ] 

Nitay Joffe commented on GIRAPH-536:
------------------------------------

You should use e.g. BooleanConfOption in places like RandomMessageBenchmark
                
> Clean up configuration options
> ------------------------------
>
>                 Key: GIRAPH-536
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-536
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>         Attachments: GIRAPH-536.patch, GIRAPH-536.patch, GIRAPH-536.patch
>
>
> Option names are all over the place, and I think they should be rationalized before we cut the 0.2 release.
> Some examples:
> 1) Options that don't start with "giraph.*", like "partition.*".
> 2) Ambiguous naming: "giraph.numInputSplitsThreads" refers to worker input threads, "giraph.inputSplitThreadCount" refers to threads used by the master to write splits to ZooKeeper.
> 3) Some options are defined in GiraphConstants, some other ones in the classes that use them. We can find all of them by searching for "static final String".
> 4) "giraph.zKForceSync" and "giraph.ZkSkipAcl" use "yes"/"no" instead of true/false, just because they are later used to write ZK configuration (which requires "yes"/"no"). I think we should stick to true/false since these are Giraph options regardless.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira