Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 38031F64C for ; Wed, 17 Apr 2013 04:19:41 +0000 (UTC) Received: (qmail 64106 invoked by uid 500); 17 Apr 2013 04:19:41 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 63896 invoked by uid 500); 17 Apr 2013 04:19:39 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 63868 invoked by uid 99); 17 Apr 2013 04:19:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Apr 2013 04:19:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F0AF01C8883; Wed, 17 Apr 2013 04:19:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5304007218802071609==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-639: Add support for multiple Vertex/Edge inputs From: "Maja Kabiljo" To: "Maja Kabiljo" , "giraph" , "Alessandro Presta" Date: Wed, 17 Apr 2013 04:19:35 -0000 Message-ID: <20130417041935.4547.82949@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maja Kabiljo" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/10564/ X-Sender: "Maja Kabiljo" References: <20130416224255.4549.52827@reviews.apache.org> In-Reply-To: <20130416224255.4549.52827@reviews.apache.org> Reply-To: "Maja Kabiljo" --===============5304007218802071609== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10564/ ----------------------------------------------------------- (Updated April 17, 2013, 4:19 a.m.) Review request for giraph. Changes ------- Alessandro's comments Description ------- For now, I did this only for Edge input, once I get some feedback I'll do t= he exactly same thing for vertex input. Also, I added direct support only to HiveGiraphRunner, we can extend it lat= er to others as well. This addresses bug GIRAPH-639. https://issues.apache.org/jira/browse/GIRAPH-639 Diffs (updated) ----- giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java 178c96f = giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 4a0e8= f7 = giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java= 7f9e38e = giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 6a5= 949e = giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphCo= nfiguration.java 8dfe546 = giraph-core/src/main/java/org/apache/giraph/io/InputFormatWithIndex.java = PRE-CREATION = giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValida= tor.java cc6b126 = giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java = d01dbb4 = giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.ja= va 029cb5d = giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java = 037cdfc = giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallabl= e.java afb636b = giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallabl= eFactory.java 4a1705b = giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 6e= 40b7f = giraph-hive/src/main/java/org/apache/giraph/hive/common/GiraphHiveConstan= ts.java f8363b1 = giraph-hive/src/main/java/org/apache/giraph/hive/common/HiveProfiles.java= 892d443 = giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeInput= Format.java c482cf0 = giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeReade= r.java 09476cd = Diff: https://reviews.apache.org/r/10564/diff/ Testing ------- mvn clean verify Run application with two edge input tables - verified results. Thanks, Maja Kabiljo --===============5304007218802071609==--