giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claudio Martella (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex
Date Wed, 10 Apr 2013 21:27:16 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628277#comment-13628277
] 

Claudio Martella commented on GIRAPH-613:
-----------------------------------------

Honestly, I do not understand your reasoning. The feature you mention was used only at FB,
as it is not in the Giraph code currently, and it was broken by another patch (which ironically
was contributed by FB itself). So it is in no way connected to this patch. 
Now, you ask me to introduce a fix for that issue in this patch, and most importantly you
ask me to introduce the fix for a feature I don't see around in the code because it's only
in the code you have at FB. So, I do not see how I can help you even if it made sense it to
be in this JIRA, as I don't have code that is using that feature to work with, so how could
I implement it?

The only thing that makes sense to me, in particular a couple of days before the release of
1.0, is that this code goes in and the other code is contributed in another issue by somebody
who actually uses it and has a clear idea of what is needed. Don't you think? Moreover, if
this code does not go in, you remain without your feature anyway, right?

Btw, the distributed test now does not have the issues it had before that I experienced a
few months ago, apparently it was fixed by one of the issues contributed so far. What is still
broken is testContinue in TextJsonBase64Format, which this code did not pass either, but it
is known to be broken for a long time (in fact it is broken also in trunk, I checked this
morning).

As far as VertexWritable, it does not mean that it's a vertex (it would be WritableVertex),
but it was called like that to emphasize the Writable interface. But I agree, it's not a great
name. What I'm going to do is take those two methods and  move them to WritableUtils.
                
> Remove Writable from the interfaces implemented by Vertex
> ---------------------------------------------------------
>
>                 Key: GIRAPH-613
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-613
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>            Priority: Minor
>         Attachments: GIRAPH-613.diff, NonWritable.diff
>
>
> Currently, Vertex implements Writable, meaning that we depend on the user (except for
the default implementation) on the way the graph is serialised and deserialized. This means
we cannot do certain optimisations, and the user can actually add additional stuff to Vertex
more than Value, Id, Edges and halt state. By removing this possibility (or allowing them
to extend a default implementation) we take control of this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message