giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex
Date Wed, 10 Apr 2013 15:26:16 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627904#comment-13627904
] 

Maja Kabiljo commented on GIRAPH-613:
-------------------------------------

Looks good overall, apart from one concern - with ByteArrayPartition we are not able to reuse
objects (vertex id, value, edges) anymore. One way to fix this would be to add additional
read method to VertexWritable which will reuse them, or have the current one check some argument
from the configuration to decide whether or not to reuse them, I think that should work.
                
> Remove Writable from the interfaces implemented by Vertex
> ---------------------------------------------------------
>
>                 Key: GIRAPH-613
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-613
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>            Priority: Minor
>         Attachments: GIRAPH-613.diff, NonWritable.diff
>
>
> Currently, Vertex implements Writable, meaning that we depend on the user (except for
the default implementation) on the way the graph is serialised and deserialized. This means
we cannot do certain optimisations, and the user can actually add additional stuff to Vertex
more than Value, Id, Edges and halt state. By removing this possibility (or allowing them
to extend a default implementation) we take control of this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message