giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-589) Remove unnecessary generics from input formats
Date Wed, 03 Apr 2013 22:27:15 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621420#comment-13621420
] 

Hudson commented on GIRAPH-589:
-------------------------------

Integrated in Giraph-trunk-Commit #864 (See [https://builds.apache.org/job/Giraph-trunk-Commit/864/])
    GIRAPH-589: Remove unnecessary generics from input formats (majakabiljo) (Revision c5c1c4c6131ee67265c4c322d53b689f9a52dc40)

     Result = SUCCESS
majakabiljo : http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=c5c1c4c6131ee67265c4c322d53b689f9a52dc40
Files : 
* giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/SimpleHiveToVertex.java
* giraph-examples/src/main/java/org/apache/giraph/examples/NormalizingLongDoubleDoubleDoubleTextInputFormat.java
* giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/AbstractHiveToEdge.java
* giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleNullDoubleTextInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/TextDoubleDoubleAdjacencyListVertexInputFormat.java
* giraph-examples/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/IntIntNullIntTextInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/VertexValueInputFormat.java
* giraph-hbase/src/main/java/org/apache/giraph/io/hbase/HBaseVertexInputFormat.java
* giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexValueInputFormat.java
* giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeReader.java
* giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java
* giraph-examples/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java
* giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleDoubleDoubleTextInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java
* giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/SimpleNoEdgesHiveToVertex.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/LongDoubleDoubleAdjacencyListVertexInputFormat.java
* giraph-accumulo/src/main/java/org/apache/giraph/io/accumulo/AccumuloVertexInputFormat.java
* giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleDoubleTextInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomVertexInputFormat.java
* giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/AbstractHiveToVertex.java
* giraph-core/src/test/java/org/apache/giraph/io/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/VertexReader.java
* giraph-examples/src/main/java/org/apache/giraph/examples/NormalizingLongDoubleDoubleTextInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/GeneratedVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInputFormat.java
* giraph-examples/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPortsTest.java
* giraph-core/src/test/java/org/apache/giraph/io/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java
* giraph-examples/src/main/java/org/apache/giraph/examples/SimpleSuperstepVertex.java
* giraph-core/src/main/java/org/apache/giraph/io/VertexInputFormat.java
* giraph-core/src/test/java/org/apache/giraph/master/TestMasterObserver.java
* giraph-examples/src/test/java/org/apache/giraph/examples/PageRankVertexTest.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/AdjacencyListTextVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/IntIntNullTextInputFormat.java
* giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/IntNullNullNullTextInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/TextVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/TextVertexValueInputFormat.java
* giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/SimpleHiveToEdge.java
* giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallable.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/JsonLongDoubleFloatDoubleVertexInputFormat.java
* giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/SequenceFileVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/IntNullNullTextInputFormat.java
* giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTestInMemory.java
* giraph-core/src/main/java/org/apache/giraph/io/BasicVertexValueReader.java
* giraph-examples/src/test/java/org/apache/giraph/examples/RandomWalkWithRestartVertexTest.java
* giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveVertexReader.java
* giraph-accumulo/src/test/java/org/apache/giraph/io/accumulo/edgemarker/AccumuloEdgeInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/VertexValueReader.java
* giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
* giraph-core/src/main/java/org/apache/giraph/io/iterables/VertexReaderWrapper.java
* giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java
* giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveToVertex.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/JsonBase64VertexInputFormat.java
* giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleNullTextInputFormat.java
* giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveVertexInputFormat.java

                
> Remove unnecessary generics from input formats
> ----------------------------------------------
>
>                 Key: GIRAPH-589
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-589
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-589.patch
>
>
> The above classes are defined in terms of I, V, E, M, while they would only require two
of them (I, V or I, E).
> I know that it might lead to unchecked casts, but I believe this is still better that
the current version, which breaks composability (what if I want to use the same HiveToVertexValue
type with different edge or message types?).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message