giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo" <majakabi...@fb.com>
Subject Re: Review Request: GIRAPH-636: Initialize compute OutEdges directly from input OutEdges
Date Thu, 18 Apr 2013 18:45:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10598/
-----------------------------------------------------------

(Updated April 18, 2013, 6:45 p.m.)


Review request for giraph.


Changes
-------

Alessandro's comments


Description
-------

Compute OutEdges can for example be immutable, or have better performance when adding all
edges than when adding one by one.


This addresses bug giraph-636.
    https://issues.apache.org/jira/browse/giraph-636


Diffs (updated)
-----

  giraph-core/src/main/java/org/apache/giraph/edge/EdgeStore.java 81044bd 
  giraph-core/src/main/java/org/apache/giraph/edge/HashMapEdges.java fc23cf0 
  giraph-core/src/main/java/org/apache/giraph/edge/HashMultimapEdges.java abe6151 
  giraph-core/src/main/java/org/apache/giraph/edge/IntNullArrayEdges.java 9867771 
  giraph-core/src/main/java/org/apache/giraph/edge/LongDoubleArrayEdges.java 45d182e 
  giraph-core/src/main/java/org/apache/giraph/edge/LongDoubleHashMapEdges.java c33200d 
  giraph-core/src/main/java/org/apache/giraph/edge/LongNullArrayEdges.java d753588 
  giraph-core/src/main/java/org/apache/giraph/edge/LongNullHashSetEdges.java ef0302c 
  giraph-core/src/main/java/org/apache/giraph/utils/EdgeIterables.java e945d7b 

Diff: https://reviews.apache.org/r/10598/diff/


Testing
-------

mvn clean verify
Application run which requires this kind of initialization


Thanks,

Maja Kabiljo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message