giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta" <alessan...@fb.com>
Subject Re: Review Request: GIRAPH-639: Add support for multiple Vertex/Edge inputs
Date Wed, 17 Apr 2013 17:11:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10564/#review19322
-----------------------------------------------------------



giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java
<https://reviews.apache.org/r/10564/#comment39999>

    Isn't the VertexInputFormat also always the same? Looks like we should only be logging
the HiveToVertex class and input description.
    Also, for uniformity with edge input formats, you may want to prepend the line "Vertex
input format:".



giraph-hive/src/main/java/org/apache/giraph/hive/common/GiraphHiveConstants.java
<https://reviews.apache.org/r/10564/#comment40001>

    Shouldn't this be "classes" too?


- Alessandro Presta


On April 17, 2013, 4:19 a.m., Maja Kabiljo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10564/
> -----------------------------------------------------------
> 
> (Updated April 17, 2013, 4:19 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> For now, I did this only for Edge input, once I get some feedback I'll do the exactly
same thing for vertex input.
> Also, I added direct support only to HiveGiraphRunner, we can extend it later to others
as well.
> 
> 
> This addresses bug GIRAPH-639.
>     https://issues.apache.org/jira/browse/GIRAPH-639
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java 178c96f 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 4a0e8f7 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 7f9e38e 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 6a5949e 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
8dfe546 
>   giraph-core/src/main/java/org/apache/giraph/io/InputFormatWithIndex.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java cc6b126

>   giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java d01dbb4 
>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 029cb5d

>   giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 037cdfc 
>   giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallable.java afb636b

>   giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallableFactory.java
4a1705b 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 6e40b7f 
>   giraph-hive/src/main/java/org/apache/giraph/hive/common/GiraphHiveConstants.java f8363b1

>   giraph-hive/src/main/java/org/apache/giraph/hive/common/HiveProfiles.java 892d443 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeInputFormat.java
c482cf0 
>   giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeReader.java 09476cd

> 
> Diff: https://reviews.apache.org/r/10564/diff/
> 
> 
> Testing
> -------
> 
> mvn clean verify
> Run application with two edge input tables - verified results.
> 
> 
> Thanks,
> 
> Maja Kabiljo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message