giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta" <alessan...@fb.com>
Subject Re: Review Request: updates
Date Fri, 12 Apr 2013 16:17:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10387/#review19075
-----------------------------------------------------------


Nitay, this patch seems full of unrelated/accidental changes. I think you didn't rebase correctly.
I noted the first few issues.


CHANGELOG
<https://reviews.apache.org/r/10387/#comment39619>

    Make sure you don't delete lines from the changelog.
    I always update it at commit time to avoid this.



giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java
<https://reviews.apache.org/r/10387/#comment39621>

    Why are you removing this?



pom.xml
<https://reviews.apache.org/r/10387/#comment39620>

    What's going on with these pom changes?


- Alessandro Presta


On April 12, 2013, 4:03 p.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10387/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 4:03 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> InternalVertexRunner.run() should take GiraphConfiguration, not GiraphClasses
> 
> 
> This addresses bug GIRAPH-595.
>     https://issues.apache.org/jira/browse/GIRAPH-595
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 23ce3d902ef374126c15ff5d3e806f90b03c86b7 
>   giraph-accumulo/pom.xml fd1ee2beb170b8c8cc141c4c9f6821f78b2476c6 
>   giraph-core/pom.xml 2f473ed764f94e61aa3bac50287424e64a13750d 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/BenchmarkOption.java 0771ca288e9d9d6b0b96b783e3beab24fb3b30f2

>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java fbb25165ef37fccdeb0de1902cc12d0b6ef259f7

>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankVertex.java 3f394b402473faebb15e7ad0338c3cd6f617f799

>   giraph-core/src/main/java/org/apache/giraph/benchmark/ShortestPathsBenchmark.java 58d3fee8162d46f3a114315fe833a89f4b65dbf8

>   giraph-core/src/main/java/org/apache/giraph/benchmark/WeightedPageRankBenchmark.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/WeightedPageRankVertex.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/combiner/FloatSumCombiner.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java d67e0a5f2cad339eec03ca9669833ce3fdf06748

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 64f8bb1bf9950d2df4ccaf0d10086e541f7d04d3

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 90b05e3c1c753094d3f1b9b5500366e011ae5426

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 95c9862b2b09a70e8c6675d799c48a09c26d1cc3

>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
f6619c1428138104dd177eb0ed55f18f2ea3fa85 
>   giraph-core/src/main/java/org/apache/giraph/edge/EdgeStore.java 01a67ddde272e8382efd9ab2b536984b55a5bb26

>   giraph-core/src/main/java/org/apache/giraph/edge/IntNullArrayEdges.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java 51ed4f6b367cd31794b411d9b4d15e8eda9af050

>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java abca4c49c10dcc166a4f23c331eeb9414fe603d5

>   giraph-core/src/main/java/org/apache/giraph/graph/Vertex.java fda6023ea7c0b0a6d8125e6ee97ac33e65babf31

>   giraph-core/src/main/java/org/apache/giraph/graph/VertexMutations.java ea50f2563ef00ec568bbcc7fb11b928e337cd4db

>   giraph-core/src/main/java/org/apache/giraph/io/formats/GiraphFileInputFormat.java fc4baa4c49ec88c7b87b2c320c14ec7359a2af12

>   giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomEdgeInputFormat.java
87cadb4b3b8204275745fd93fa15eb43fe92bc46 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomIntNullLocalEdgesHelper.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomIntNullVertexInputFormat.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomUtils.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomVertexInputFormat.java
dca0271a2acc5802811aedb79f72642529aefb6d 
>   giraph-core/src/main/java/org/apache/giraph/master/MasterInfo.java 96e988c0df663064905f79e31ee58a3116b837e8

>   giraph-core/src/main/java/org/apache/giraph/partition/ByteArrayPartition.java dd8c974ec6ce1b63bef2cabc6a4ece3b2a7c23c0

>   giraph-core/src/main/java/org/apache/giraph/partition/DiskBackedPartitionStore.java
352530274f44789b84d0af42d4cd4c9f06b18811 
>   giraph-core/src/main/java/org/apache/giraph/partition/SimplePartition.java 23e0f053cb98e515add370e6f9a39fa6dcf55dea

>   giraph-core/src/main/java/org/apache/giraph/utils/CallableFactory.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 9ebe69301e2c42eb4d96c9916d4acb72ae795fa2

>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java e389e013e563cb0748b2e2d0b8b7f6e059e666b9

>   giraph-core/src/main/java/org/apache/giraph/utils/ProgressableUtils.java 77eb49a7692fdd16a9ed4bee95d554870250ade6

>   giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java e5c2fddbc93a9996f67297c786518584ddc3f0e0

>   giraph-core/src/main/java/org/apache/giraph/utils/WritableUtils.java 6e7b87a07238dfdaec7c108d616bdf14d8fc12e1

>   giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java c20d06e2adee8bdd8dd619ffe2171edf37287ceb

>   giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallableFactory.java
9297ac1ddeb5f3abbbec1ba52df1397e4953d55d 
>   giraph-core/src/main/java/org/apache/giraph/worker/InputSplitsCallableFactory.java
cdc6543561eb3c2649c8f0901352e888fef1a4cf 
>   giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallableFactory.java
aebca81f912ff1395cd119d00b771e7c1768ce43 
>   giraph-core/src/site/resources/css/site.css bd3e914cb7e3a13ee85e821fb2d73650077c4a03

>   giraph-core/src/site/resources/images/ApacheGiraph.svg 8c339c8fea13be1ed5d6280c61fe9271e636917f

>   giraph-core/src/site/site.xml 24b7ab25ed2103c6c96e68d7e73d64977a2851cb 
>   giraph-core/src/site/xdoc/index.xml 2d496a229ae0db933c0a94047ec0c4dddfebabe4 
>   giraph-core/src/test/java/org/apache/giraph/BspCase.java f3c3358d028fa2118ac0c2d41fa29875076a3db1

>   giraph-core/src/test/java/org/apache/giraph/graph/TestVertexAndEdges.java fb5b68570161601f24e740afc8c285f870889005

>   giraph-core/src/test/java/org/apache/giraph/io/TestEdgeInput.java 0dcefd9191c4fc524dd986c24f8777c5bf00240d

>   giraph-core/src/test/java/org/apache/giraph/io/TestJsonBase64Format.java 0117ce93c3d0607cc80cf8f7b584c4e65f99c8ce

>   giraph-core/src/test/java/org/apache/giraph/master/TestMasterObserver.java 8cd427ef195789a499bdabef894b359cfa400ad7

>   giraph-examples/pom.xml 21e8ccfc20042b14fcd2059272522001d566e716 
>   giraph-examples/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java
8a98e755811cabedbd5f16b88590f76ea4a0c56b 
>   giraph-examples/src/test/java/org/apache/giraph/TestAutoCheckpoint.java 386f67bdac272ed58770def912715ccb1b4d7297

>   giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java ab88b88636f3841dd51bf9a793a98726765cc8a5

>   giraph-examples/src/test/java/org/apache/giraph/TestGraphPartitioner.java f7fa3f29c7821b7506bdd8b38e46c3992eafa90b

>   giraph-examples/src/test/java/org/apache/giraph/TestManualCheckpoint.java 210b78ae3a704f6974740dd29c23484965fc78b2

>   giraph-examples/src/test/java/org/apache/giraph/TestMaxSuperstep.java d7ac4e8846cc621269675e301532257318f4bcf5

>   giraph-examples/src/test/java/org/apache/giraph/TestMutateGraph.java 0427b85e6fd18e8565a7ce8b34c3e7300046e84a

>   giraph-examples/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java 759624b1141b547f936cf0b4b0e554633fe01195

>   giraph-examples/src/test/java/org/apache/giraph/TestPartitionContext.java f236128823ee03f9793f0955f3d4e2c1effa2f60

>   giraph-examples/src/test/java/org/apache/giraph/aggregators/TestAggregatorsHandling.java
372c32fb6bf9b94a37ed7a808525d483951c815a 
>   giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java
55ca60ca95304d80ea0be084b42b93cb05822888 
>   giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTestInMemory.java
e42f1727297fb40b4cf4c968f94868a40a67bf30 
>   giraph-examples/src/test/java/org/apache/giraph/examples/PageRankVertexTest.java 042dbe4c37f345515bb328a7dc544bd8a2d33a73

>   giraph-examples/src/test/java/org/apache/giraph/examples/RandomWalkWithRestartVertexTest.java
f77ea3ee6e2f514e5401771cb5fee3536ba2159c 
>   giraph-examples/src/test/java/org/apache/giraph/examples/SimpleShortestPathsVertexTest.java
e51b611efe99ba9e7decbc24bdcd605facd284ca 
>   giraph-examples/src/test/java/org/apache/giraph/examples/TestPageRank.java 448afe674984ec0cadd7c38b64f9e9d14428ae4b

>   giraph-examples/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPortsTest.java
48153aeebcda5d56fabb8602b402c9355d71864f 
>   giraph-hbase/pom.xml 41b27e82aac24ded3ccb06eba527f5f8cf70bceb 
>   giraph-hcatalog/pom.xml ee5710a67fcda5fdc5a77e9cdf4a2fc9e9722c88 
>   giraph-hive/pom.xml 2f80165ff6ecd4f255f8c6e9cd3acdf07c872817 
>   pom.xml 71467cdc1ef83ad835ab7522e6112e8c1389a772 
>   src/site/resources/css/site.css PRE-CREATION 
>   src/site/resources/images/ApacheGiraph.svg PRE-CREATION 
>   src/site/site.xml PRE-CREATION 
>   src/site/xdoc/build_site.xml PRE-CREATION 
>   src/site/xdoc/generating_patches.xml PRE-CREATION 
>   src/site/xdoc/index.xml PRE-CREATION 
>   src/site/xdoc/javadoc_modules.xml PRE-CREATION 
>   src/site/xdoc/pagerank.xml PRE-CREATION 
>   src/site/xdoc/presentations.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10387/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message