giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Schelter" <...@apache.org>
Subject Re: Review Request: InternalVertexRunner.run() should take GiraphConfiguration, not GiraphClasses
Date Wed, 10 Apr 2013 05:11:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10387/#review18923
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Schelter


On April 9, 2013, 10:47 p.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10387/
> -----------------------------------------------------------
> 
> (Updated April 9, 2013, 10:47 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> InternalVertexRunner.run() should take GiraphConfiguration, not GiraphClasses
> 
> 
> This addresses bug GIRAPH-595.
>     https://issues.apache.org/jira/browse/GIRAPH-595
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 23ce3d902ef374126c15ff5d3e806f90b03c86b7 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java fbb25165ef37fccdeb0de1902cc12d0b6ef259f7

>   giraph-core/src/main/java/org/apache/giraph/benchmark/ShortestPathsBenchmark.java 58d3fee8162d46f3a114315fe833a89f4b65dbf8

>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java d67e0a5f2cad339eec03ca9669833ce3fdf06748

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 90b05e3c1c753094d3f1b9b5500366e011ae5426

>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
f6619c1428138104dd177eb0ed55f18f2ea3fa85 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 9ebe69301e2c42eb4d96c9916d4acb72ae795fa2

>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java e389e013e563cb0748b2e2d0b8b7f6e059e666b9

>   giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java e5c2fddbc93a9996f67297c786518584ddc3f0e0

>   giraph-core/src/test/java/org/apache/giraph/BspCase.java f3c3358d028fa2118ac0c2d41fa29875076a3db1

>   giraph-core/src/test/java/org/apache/giraph/io/TestEdgeInput.java 0dcefd9191c4fc524dd986c24f8777c5bf00240d

>   giraph-core/src/test/java/org/apache/giraph/master/TestMasterObserver.java 8cd427ef195789a499bdabef894b359cfa400ad7

>   giraph-examples/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java
8a98e755811cabedbd5f16b88590f76ea4a0c56b 
>   giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java ab88b88636f3841dd51bf9a793a98726765cc8a5

>   giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java
55ca60ca95304d80ea0be084b42b93cb05822888 
>   giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTestInMemory.java
e42f1727297fb40b4cf4c968f94868a40a67bf30 
>   giraph-examples/src/test/java/org/apache/giraph/examples/PageRankVertexTest.java 042dbe4c37f345515bb328a7dc544bd8a2d33a73

>   giraph-examples/src/test/java/org/apache/giraph/examples/RandomWalkWithRestartVertexTest.java
f77ea3ee6e2f514e5401771cb5fee3536ba2159c 
>   giraph-examples/src/test/java/org/apache/giraph/examples/SimpleShortestPathsVertexTest.java
e51b611efe99ba9e7decbc24bdcd605facd284ca 
>   giraph-examples/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPortsTest.java
48153aeebcda5d56fabb8602b402c9355d71864f 
> 
> Diff: https://reviews.apache.org/r/10387/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message