giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta" <alessan...@fb.com>
Subject Re: Review Request: PageRankBenchmark -> WeightedPageRankBenchmark and create FastPageRankBenchmark
Date Mon, 08 Apr 2013 19:41:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10343/#review18791
-----------------------------------------------------------


Weighted PageRank doesn't seem particularly significant in the literature. I'd rather keep
just one (standard) PageRankBenchmark.
Also, why would it hurt to keep the current options? We can still use the benchmark to test
vertex/edge input, edge locality, and different VertexEdges implementations, as long as the
defaults are the fastest.
Edge locality especially seems something we should keep in the benchmark, since it can show
how Giraph behaves with smartly-partitioned data.

- Alessandro Presta


On April 8, 2013, 6:23 p.m., Maja Kabiljo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10343/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 6:23 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> Make two benchmarks for page rank:
> - WeightedPageRankBenchmark which corresponds to current PageRankBenchmark (has all the
options for testing different stuff), changed the vertex implementation to use the weights
of the edges in the computation
> - FastPageRankBenchmark, which we can use to show how fast Giraph really is :-) It uses
integers for vertex ids, floats for page ranks, it's unweighted and doesn't have all the options
from PageRankBenchmark, but just the basic stuff
> 
> 
> This addresses bug giraph-543.
>     https://issues.apache.org/jira/browse/giraph-543
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/FastPageRankBenchmark.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/benchmark/FastPageRankVertex.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java fbb2516

>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankVertex.java 3f394b4 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/WeightedPageRankBenchmark.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/WeightedPageRankVertex.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/combiner/FloatSumCombiner.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/edge/IntNullArrayEdges.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomEdgeInputFormat.java
87cadb4 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomIntNullVertexInputFormat.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomUtils.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomVertexInputFormat.java
dca0271 
>   giraph-core/src/test/java/org/apache/giraph/io/TestJsonBase64Format.java 0117ce9 
> 
> Diff: https://reviews.apache.org/r/10343/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maja Kabiljo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message