giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta" <alessan...@fb.com>
Subject Review Request: GIRAPH-606: Configure classes by default when possible
Date Fri, 05 Apr 2013 22:45:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10320/
-----------------------------------------------------------

Review request for giraph.


Description
-------

Now that DefaultImmutableClassesGiraphConfigurable has been created, we can clean up some
custom implementations of ICGC (Vertex and ConfigurableVertexEdges).


This addresses bug GIRAPH-606.
    https://issues.apache.org/jira/browse/GIRAPH-606


Diffs
-----

  giraph-core/src/main/java/org/apache/giraph/edge/ArrayListEdges.java dda75684dea466093bbdd4086fc29dd4b4e378da

  giraph-core/src/main/java/org/apache/giraph/edge/ByteArrayEdges.java 16748ef8bbc795a3fffdd18aecada4f79fd5dc44

  giraph-core/src/main/java/org/apache/giraph/edge/ConfigurableVertexEdges.java faa12ebffa6400cbe49c11e43360e4b978d902ae

  giraph-core/src/main/java/org/apache/giraph/edge/HashMapEdges.java 9fa7b64528773e5239b4f1504f8fceaa5263fcf6

  giraph-core/src/main/java/org/apache/giraph/edge/HashMultimapEdges.java 123d49f9afca71e62026f27291c54392b92ff55c

  giraph-core/src/main/java/org/apache/giraph/edge/LongDoubleArrayEdges.java 0487d920899d3b9fe0112c4a553d4087d9179a7e

  giraph-core/src/main/java/org/apache/giraph/edge/LongDoubleHashMapEdges.java 867a35691504d76bf6c9e0382af4beb0ab8d2c0a

  giraph-core/src/main/java/org/apache/giraph/edge/LongNullArrayEdges.java de4e310cad198f45c110642bbdb6171abcc9dc8e

  giraph-core/src/main/java/org/apache/giraph/edge/LongNullHashSetEdges.java 094d4715607e5efce7c05bb3e62d547e4a981a40

  giraph-core/src/main/java/org/apache/giraph/graph/Vertex.java 30312745a9235d923335b94969a8d2921242da27

  giraph-core/src/main/java/org/apache/giraph/io/iterables/VertexReaderWrapper.java 927ec3f307c7ec66af8c725c6436ec97ddc96da3

  giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java 7d02533097875867ffcecdc98d3639e814694981

  giraph-core/src/test/java/org/apache/giraph/BspCase.java 4c74d3fbc69881a5f120512b1bebab9f92534900

  giraph-core/src/test/java/org/apache/giraph/utils/MockUtils.java 3a0e14401caf613acec0b411d158cf115cb1619b


Diff: https://reviews.apache.org/r/10320/diff/


Testing
-------

mvn verify


Thanks,

Alessandro Presta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message