Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@giraph.apache.org
Date: Wed, 20 Mar 2013 19:07:15 +0000 (UTC)
From: "Nitay Joffe (JIRA)" <jira@apache.org>
To: giraph-dev@incubator.apache.org
Message-ID: <JIRA.12638027.1363802166227.21424.1363806435893@arcas>
In-Reply-To: <JIRA.12638027.1363802166227@arcas>
References: <JIRA.12638027.1363802166227@arcas>
Subject: [jira] [Commented] (GIRAPH-576) BspServiceMaster.failureCleanup()
 shouldn't pass null in observers' applicationFailed() method
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/GIRAPH-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608026#comment-13608026 ] 

Nitay Joffe commented on GIRAPH-576:
------------------------------------

Also make sure to click "Submit patch" when you want to mark that it should be reviewed.
                
> BspServiceMaster.failureCleanup() shouldn't pass null in observers' applicationFailed() method
> ----------------------------------------------------------------------------------------------
>
>                 Key: GIRAPH-576
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-576
>             Project: Giraph
>          Issue Type: Bug
>          Components: bsp
>    Affects Versions: 0.2.0
>         Environment: Linux
>            Reporter: Jess Garms
>            Priority: Minor
>              Labels: easy, newbie, patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-576.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> failureCleanup() in BspServiceMaster gets called with a null exception from failJob(). That in turn passes a null exception to the set of MasterObservers, in their applicationFailed() method. They probably aren't expecting that. Instead we should pass an appropriate exception around depending on the cause of the failure.
> I'll attach a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira