Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 33A17F65E for ; Fri, 29 Mar 2013 21:33:00 +0000 (UTC) Received: (qmail 52156 invoked by uid 500); 29 Mar 2013 21:33:00 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 52121 invoked by uid 500); 29 Mar 2013 21:33:00 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 52108 invoked by uid 99); 29 Mar 2013 21:33:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Mar 2013 21:33:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6B8E11C10EA; Fri, 29 Mar 2013 21:32:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5033359071279414988==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-600: Create an option to do output during computation From: "Sebastian Schelter" To: "Sebastian Schelter" , "Maja Kabiljo" , "giraph" Date: Fri, 29 Mar 2013 21:32:58 -0000 Message-ID: <20130329213258.12538.9442@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sebastian Schelter" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/10201/ X-Sender: "Sebastian Schelter" References: <20130329211311.12496.88365@reviews.apache.org> In-Reply-To: <20130329211311.12496.88365@reviews.apache.org> Reply-To: "Sebastian Schelter" --===============5033359071279414988== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10201/#review18537 ----------------------------------------------------------- Ship it! I only had one minor comment in the classes that handles the writers for mu= ltithreaded output. Other than that, the patch looks fine. - Sebastian Schelter On March 29, 2013, 9:13 p.m., Maja Kabiljo wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10201/ > ----------------------------------------------------------- > = > (Updated March 29, 2013, 9:13 p.m.) > = > = > Review request for giraph. > = > = > Description > ------- > = > https://issues.apache.org/jira/browse/GIRAPH-600 > = > = > This addresses bug GIRAPH-600. > https://issues.apache.org/jira/browse/GIRAPH-600 > = > = > Diffs > ----- > = > giraph-core/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorke= r.java 56b5d03 = > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.ja= va 963b82a = > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java c= 5b9b93 = > giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraph= Configuration.java 76f6105 = > giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java = 4840471 = > giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java= 57f7dff = > giraph-core/src/main/java/org/apache/giraph/io/SimpleVertexWriter.java = PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/io/VertexWriter.java 38c554= 8 = > giraph-core/src/main/java/org/apache/giraph/io/superstep_output/MultiTh= readedSuperstepOutput.java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/io/superstep_output/NoOpSup= erstepOutput.java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/io/superstep_output/Superst= epOutput.java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/io/superstep_output/Synchro= nizedSuperstepOutput.java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/io/superstep_output/package= -info.java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.jav= a 74c1f87 = > = > Diff: https://reviews.apache.org/r/10201/diff/ > = > = > Testing > ------- > = > mvn clean install > Real application using SynchronizedSuperstepOutput > = > = > Thanks, > = > Maja Kabiljo > = > --===============5033359071279414988==--