Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 35875FAB0 for ; Wed, 27 Mar 2013 16:20:20 +0000 (UTC) Received: (qmail 48267 invoked by uid 500); 27 Mar 2013 16:20:20 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 48229 invoked by uid 500); 27 Mar 2013 16:20:20 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 48216 invoked by uid 99); 27 Mar 2013 16:20:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Mar 2013 16:20:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 754901C10E8; Wed, 27 Mar 2013 16:20:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4960851713605842802==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-588: More flexible Hive input From: "Maja Kabiljo" To: "Nitay Joffe" Cc: "Maja Kabiljo" , "giraph" Date: Wed, 27 Mar 2013 16:20:18 -0000 Message-ID: <20130327162018.12538.10626@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maja Kabiljo" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/10126/ X-Sender: "Maja Kabiljo" References: <20130327031841.12496.61778@reviews.apache.org> In-Reply-To: <20130327031841.12496.61778@reviews.apache.org> Reply-To: "Maja Kabiljo" --===============4960851713605842802== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On March 27, 2013, 3:18 a.m., Nitay Joffe wrote: > > I love where this is going, awesome work! The only thing that bugs me a= bit is all the wrappers - it makes the code a bit hard to understand so I = worry about new users. Could we get rid of some of the wrappers if we carry= the Iterator<> interface up through to Edge/VertexReader themselves. I'm not sure what do you mean. As we discussed offline, eventually we can h= ave all readers implementing Iterator, but that's a big change so we can ma= ke it in several parts. Also, wrappers are not visible to the user, he should be working only with = HiveToEdge/SimpleHiveToEdge etc. > On March 27, 2013, 3:18 a.m., Nitay Joffe wrote: > > giraph-hive/src/main/java/org/apache/giraph/hive/input/RecordReaderWrap= per.java, line 34 > > > > > > Look into Guava's AbstractIterator, it might make this easier/clean= er to implement? Awesome, didn't know about that class. Much cleaner :-) > On March 27, 2013, 3:18 a.m., Nitay Joffe wrote: > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/AbstractHiv= eToEdge.java, line 37 > > > > > > Maybe add default implementation of remove() that throws Unsupporte= dOperationException so others don't have to have the method unless they rea= lly want to. Could also make it final if we don't want to allow removal eve= r? Good idea > On March 27, 2013, 3:18 a.m., Nitay Joffe wrote: > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveToVer= tex.java, line 41 > > > > > > I take it you removed HiveToVertexValue because you're going to ess= entially reimplement that with a HiveToEdge that reads single row =3D> mult= iple edges? Cool! You mean HiveToVertexEdges? No, that would be more expensive. From what I u= nderstood in the current implementation, HiveToVertexEdges is just an exten= sion to HiveToVertexValue. Now HiveTovertex can read both values and edges,= and SimpleNoEdgesHiveToVertex is for the cases when we have no edges. - Maja ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10126/#review18414 ----------------------------------------------------------- On March 27, 2013, 4:19 p.m., Maja Kabiljo wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10126/ > ----------------------------------------------------------- > = > (Updated March 27, 2013, 4:19 p.m.) > = > = > Review request for giraph and Nitay Joffe. > = > = > Description > ------- > = > Currently with Hive input formats it's only possible to convert single ro= w to single vertex/edge. We should support some rows to be skipped. General= multiple rows to multiple vertices/edges conversion can be useful (one exa= mple - we have edge input, sorted by source id, and we want to keep only to= p k weighted edges per vertex). > = > Added some wrappers for readers to convert them to Iterator-like classes. > = > = > This addresses bug GIRAPH-588. > https://issues.apache.org/jira/browse/GIRAPH-588 > = > = > Diffs > ----- > = > giraph-core/src/main/java/org/apache/giraph/io/iterables/EdgeReaderWrap= per.java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/io/iterables/EdgeWithSource= .java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/io/iterables/GiraphReader.j= ava PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/io/iterables/IteratorToRead= erWrapper.java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/io/iterables/VertexReaderWr= apper.java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/io/iterables/package-info.j= ava PRE-CREATION = > giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java = efc08d3 = > giraph-hive/src/main/java/org/apache/giraph/hive/common/DefaultConfigur= ableAndTableSchemaAware.java PRE-CREATION = > giraph-hive/src/main/java/org/apache/giraph/hive/input/RecordReaderWrap= per.java PRE-CREATION = > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/AbstractHiv= eToEdge.java f29fea7 = > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeInp= utFormat.java 18b40c2 = > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeRea= der.java 6fb183a = > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveToEdge.= java 2205b82 = > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/SimpleHiveT= oEdge.java PRE-CREATION = > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/AbstractH= iveToVertex.java PRE-CREATION = > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/AbstractH= iveToVertexEdges.java d0668f6 = > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/AbstractH= iveToVertexValue.java 9ab316f = > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveToVer= tex.java PRE-CREATION = > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveToVer= texEdges.java 8076a8a = > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveToVer= texValue.java 593eb9a = > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveVerte= xInputFormat.java 25c7a26 = > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveVerte= xReader.java 541176f = > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/SimpleHiv= eToVertex.java PRE-CREATION = > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/SimpleNoE= dgesHiveToVertex.java PRE-CREATION = > giraph-hive/src/main/java/org/apache/giraph/hive/output/AbstractVertexT= oHive.java 8e3f1ca = > = > Diff: https://reviews.apache.org/r/10126/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Maja Kabiljo > = > --===============4960851713605842802==--