Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 430C9F9B7 for ; Tue, 26 Mar 2013 21:59:08 +0000 (UTC) Received: (qmail 33294 invoked by uid 500); 26 Mar 2013 21:59:08 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 33260 invoked by uid 500); 26 Mar 2013 21:59:08 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 33249 invoked by uid 99); 26 Mar 2013 21:59:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Mar 2013 21:59:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 40DD21C356E; Tue, 26 Mar 2013 21:59:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6859692628481564386==" MIME-Version: 1.0 Subject: Re: Review Request: In memory testing framework added From: "Alessandro Presta" To: "giraph" , "Veselin Stoyanov" , "Alessandro Presta" Date: Tue, 26 Mar 2013 21:59:06 -0000 Message-ID: <20130326215906.12538.61368@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Alessandro Presta" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/10052/ X-Sender: "Alessandro Presta" References: <20130320225601.6686.54283@reviews.apache.org> In-Reply-To: <20130320225601.6686.54283@reviews.apache.org> Reply-To: "Alessandro Presta" --===============6859692628481564386== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On March 20, 2013, 10:56 p.m., Alessandro Presta wrote: > > giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInput.j= ava, line 129 > > > > > > I would call this "getEdges", maybe "createEdges". Also, looks like= it could be converted to a static method. > = > Veselin Stoyanov wrote: > I changed the name, but if I make it static, I can't use the generic = types. Can't you make it a generic method? > On March 20, 2013, 10:56 p.m., Alessandro Presta wrote: > > giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInput.j= ava, line 170 > > > > > > Assigning the format's conf from the reader doesn't feel right. > > You can instead make the format implement ImmutableClassesGiraphCon= figurable, so that Giraph will provide it with the conf upon instantiation. > = > Veselin Stoyanov wrote: > I was going by the way that this is done in io.formats.TextVertexInpu= tFormat (line 101). I can change it if you think it's better. Yes, I think it's better. A member class setting a field of the enclosing c= lass seems error-prone. - Alessandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10052/#review18177 ----------------------------------------------------------- On March 26, 2013, 9:25 p.m., Veselin Stoyanov wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10052/ > ----------------------------------------------------------- > = > (Updated March 26, 2013, 9:25 p.m.) > = > = > Review request for giraph. > = > = > Description > ------- > = > A framework for running small test graphs in memory. > = > = > Diffs > ----- > = > giraph-core/src/main/java/org/apache/giraph/utils/InMemoryEdgeInput.jav= a PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInput.j= ava PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexOutput.= java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.= java 7e0b955998a5f1890912819fa2ca74fbbf46fedd = > giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java PRE-CR= EATION = > giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedCompo= nentsVertexTestInMemory.java PRE-CREATION = > = > Diff: https://reviews.apache.org/r/10052/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Veselin Stoyanov > = > --===============6859692628481564386==--