giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jess Garms (JIRA)" <j...@apache.org>
Subject [jira] [Created] (GIRAPH-576) BspServiceMaster.failureCleanup() shouldn't pass null in observers' applicationFailed() method
Date Wed, 20 Mar 2013 17:57:15 GMT
Jess Garms created GIRAPH-576:
---------------------------------

             Summary: BspServiceMaster.failureCleanup() shouldn't pass null in observers'
applicationFailed() method
                 Key: GIRAPH-576
                 URL: https://issues.apache.org/jira/browse/GIRAPH-576
             Project: Giraph
          Issue Type: Bug
          Components: bsp
    Affects Versions: 0.2.0
         Environment: Linux
            Reporter: Jess Garms
            Priority: Minor
             Fix For: 0.2.0


failureCleanup() in BspServiceMaster gets called with a null exception from failJob(). That
in turn passes a null exception to the set of MasterObservers, in their applicationFailed()
method. They probably aren't expecting that. Instead we should pass an appropriate exception
around depending on the cause of the failure.

I'll attach a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message