giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-545) Improve Facebook Hadoop dependency
Date Fri, 01 Mar 2013 18:11:13 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590787#comment-13590787
] 

Nitay Joffe commented on GIRAPH-545:
------------------------------------

Here's my rough notes: https://gist.github.com/nitay/928079d0e68b6b62254c
If we need to update the jar next time I can do it in a script and save the commands.
+1?
                
> Improve Facebook Hadoop dependency
> ----------------------------------
>
>                 Key: GIRAPH-545
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-545
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>         Attachments: GIRAPH-545.patch
>
>
> The Facebook Hadoop dependency uses a local path (systemPath in maven) which is bad for
many reasons. See e.g. http://docs.codehaus.org/display/MAVENUSER/Dependency+Scopes (the part
about system scope). Amongst the problems are:
> - We package the jar ourselves in our lib/ folder
> - Anyone depending on Giraph needs to download jars themselves and put them in right
place, but we don't supply the jars.
> - There is no javadoc or sources jar which comes with most open source maven projects
and is really handy
> So I went ahead and created a package from Facebook's code on Github and published the
jar to maven central. This diff updates our code to use that, which fixes all of the problems
mentioned above.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message