giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GIRAPH-537) Fix log messages produced by aggregators
Date Wed, 20 Mar 2013 18:41:16 GMT

     [ https://issues.apache.org/jira/browse/GIRAPH-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Maja Kabiljo updated GIRAPH-537:
--------------------------------

    Attachment: GIRAPH-537.patch

Final patch from rb, committing with Alessandro's +1
                
>  Fix log messages produced by aggregators
> -----------------------------------------
>
>                 Key: GIRAPH-537
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-537
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-537.patch, GIRAPH-537.patch
>
>
> When workers are synchronizing aggregators using the ExpectedBarrier class, the following
message is printed:
> "waitForRequiredPermits: Waiting for times required to be X (currently Y)"
> I find this doesn't convey much about what exactly we're waiting for.
> We should make the log more meaningful and explicitly mention aggregators, at the cost
of simplifying things a bit.
> Additionally, we could skip it altogether when no aggregators are being used.
> The ExpectedBarrier class itself also lacks clear documentation: what is this class for?
The Javadoc explains how it works without first stating what it is.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message