giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Schelter" <...@apache.org>
Subject Re: Review Request: GIRAPH-600: Create an option to do output during computation
Date Fri, 29 Mar 2013 21:32:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10201/#review18537
-----------------------------------------------------------

Ship it!


I only had one minor comment in the classes that handles the writers for multithreaded output.
Other than that, the patch looks fine.

- Sebastian Schelter


On March 29, 2013, 9:13 p.m., Maja Kabiljo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10201/
> -----------------------------------------------------------
> 
> (Updated March 29, 2013, 9:13 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/GIRAPH-600
> 
> 
> This addresses bug GIRAPH-600.
>     https://issues.apache.org/jira/browse/GIRAPH-600
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java 56b5d03

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 963b82a 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java c5b9b93 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
76f6105 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java 4840471 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 57f7dff 
>   giraph-core/src/main/java/org/apache/giraph/io/SimpleVertexWriter.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/io/VertexWriter.java 38c5548 
>   giraph-core/src/main/java/org/apache/giraph/io/superstep_output/MultiThreadedSuperstepOutput.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/superstep_output/NoOpSuperstepOutput.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/superstep_output/SuperstepOutput.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/superstep_output/SynchronizedSuperstepOutput.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/superstep_output/package-info.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 74c1f87 
> 
> Diff: https://reviews.apache.org/r/10201/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> Real application using SynchronizedSuperstepOutput
> 
> 
> Thanks,
> 
> Maja Kabiljo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message