giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta" <alessan...@fb.com>
Subject Re: Review Request: In memory testing framework added
Date Fri, 29 Mar 2013 05:20:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10052/#review18492
-----------------------------------------------------------


One last thing you forgot to address, then we can ship.


giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTestInMemory.java
<https://reviews.apache.org/r/10052/#comment38784>

    You forgot to make TestGraph implement Iterable<Vertex> instead of Iterable<I>,
which will make this pattern a bit cleaner:
    
    for (Vertex<I, V, E, M> vertex : results) {
      components.put(vertex.getValue().get(), vertex.getId().get());
    }
    
    I would only use getVertex() when we need to check a condition against a specific vertex.


- Alessandro Presta


On March 29, 2013, 4:34 a.m., Veselin Stoyanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10052/
> -----------------------------------------------------------
> 
> (Updated March 29, 2013, 4:34 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> A framework for running small test graphs in memory.
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInputFormat.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 4b03127f3490d35e6e3ddf7b69a9d0bc4673420d

>   giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java PRE-CREATION 
>   giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTestInMemory.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10052/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veselin Stoyanov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message