giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Schelter" <...@apache.org>
Subject Re: Review Request: GIRAPH-587: Refactor configuration options
Date Wed, 27 Mar 2013 23:10:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10156/#review18448
-----------------------------------------------------------

Ship it!


I'm no fan of excessive static imports, but that's just personal taste. Other than that, I
really like the refactoring and I think it greatly enhances readability of the code.

- Sebastian Schelter


On March 27, 2013, 11:03 p.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10156/
> -----------------------------------------------------------
> 
> (Updated March 27, 2013, 11:03 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> See https://issues.apache.org/jira/browse/GIRAPH-587
> 
> 
> Diffs
> -----
> 
>   checkstyle.xml 3d8a6d41388f97cbc50fc76d66e286c4d5a0bf1a 
>   giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java 2902fa9d321350364fedf481c95829cd9406db00

>   giraph-core/src/main/java/org/apache/giraph/benchmark/ShortestPathsBenchmark.java 1753f4ff9146fe598d209886c6f3e3087b204261

>   giraph-core/src/main/java/org/apache/giraph/bsp/BspInputFormat.java bce84b1d839f08eb6e569fb59e52dd7966e9bbb5

>   giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java 969e2a5089279bddbdc75be847b681f6f1fda25a

>   giraph-core/src/main/java/org/apache/giraph/comm/SendEdgeCache.java 679cf6fffb97a526fd8f122c9f73399bd81b28f9

>   giraph-core/src/main/java/org/apache/giraph/comm/SendMessageCache.java 07dc380a4bc1dd50ce12d6c06bea4f6c71bf6a1b

>   giraph-core/src/main/java/org/apache/giraph/comm/ServerData.java 70dc156adfc804d9a9af6442543e1555c3687a27

>   giraph-core/src/main/java/org/apache/giraph/comm/messages/SequentialFileMessageStore.java
bdc543571c7a40cb28c5096f41ea12951ecdca9d 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java af76410f0ccf512d63939398d4afacbc0cdc449a

>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyServer.java f31dd4af0d06dd48e6dbe401e3c60860e83789e9

>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
e58030e4b6d016eef47bf46fdc0d4eccec93826f 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerServer.java 1fb0580325ebae880fdbed94925edad70ca7f750

>   giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/RequestEncoder.java
4e739cb1a32d8e1c2869d701845a57029f2ba238 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/RequestServerHandler.java
bbf31c78ca539287fcda50ba2f062f9f86e8d682 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/ResponseClientHandler.java
1803be4820347a5c92f5a052fc16bb90f588e2e2 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/SaslServerHandler.java
d06fd09a00fbd4e0799daadf151ab58ff58478e5 
>   giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java c13f3a268edc0d514314d8813ce0e59dd4ed056f

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java ffcae6e79cf0bd96745ef9bc9fc420f5b28494b2

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 7882d06fddd70eb9fef7a8d0463c6618b39d3d4d

>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
de85ab63306b63145159cfaf3d587fcef8ae58ce 
>   giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java e74c59a91b80ac69e0aa53b04a3669329a87ac2f

>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java 1e0577373e6627d35976c6c2d4b2264b3546e62f

>   giraph-core/src/main/java/org/apache/giraph/job/GiraphJob.java da85d1cfd5d5b42e9c3173f10a466c6b03b941b4

>   giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java 6c979d6aaf78000521083f5374c56341867551aa

>   giraph-core/src/main/java/org/apache/giraph/master/MasterThread.java 40c6b740315b40b68e9300991869e6b0a203b2ca

>   giraph-core/src/main/java/org/apache/giraph/partition/DiskBackedPartitionStore.java
6bc95917efe4acdaca19f4a390e8dcb9824d7675 
>   giraph-core/src/main/java/org/apache/giraph/partition/PartitionUtils.java c83ca456cbaf6bba26421f4f766b07cc35665cdd

>   giraph-core/src/main/java/org/apache/giraph/partition/SimplePartition.java ae8556fd47fa1d2c1a8fd0c0b7fb4bb95215c044

>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 2bba6724cd5dd4aaa5d94b0cefdefcd7fdb4fa7c

>   giraph-core/src/main/java/org/apache/giraph/utils/JMapHistoDumper.java 463510fb1fe4b54fe4469cec43eacb5b1198f768

>   giraph-core/src/main/java/org/apache/giraph/zk/GiraphZooKeeperAdmin.java 7589a0908e720570812d658612dfa5617ffad828

>   giraph-core/src/main/java/org/apache/giraph/zk/ZooKeeperManager.java add57fcaaf15ff5400df1ce700851f9356296f81

>   giraph-core/src/test/java/org/apache/giraph/BspCase.java a6eef20429508184f0b8cb050f74553720022467

>   giraph-core/src/test/java/org/apache/giraph/comm/RequestFailureTest.java cc7cb171333509dfbca43dd3d0361fb5ed13537f

>   giraph-core/src/test/java/org/apache/giraph/comm/RequestTest.java c8d6b3b7667b9dfe6e6dabe904b37cf8be7ee121

>   giraph-core/src/test/java/org/apache/giraph/comm/SaslConnectionTest.java 3094f3e64a246ae5c9ec8cda8b8ef7d7a4605f05

>   giraph-core/src/test/java/org/apache/giraph/conf/TestGiraphConfiguration.java cd3719732e92a62d4f2507d60b6a7874e264943e

>   giraph-core/src/test/java/org/apache/giraph/conf/TestObjectCreation.java 9f0920a5349ddc6a228035ea386fd55e799702a8

>   giraph-core/src/test/java/org/apache/giraph/master/TestMasterObserver.java 54a8b92ff37780a61e1f615f764af897dba03988

>   giraph-core/src/test/java/org/apache/giraph/partition/TestPartitionStores.java d403dd8e132be16e7d080f76b6b2b63fe574fc5a

>   giraph-examples/src/test/java/org/apache/giraph/TestAutoCheckpoint.java efbe320bd8ed96ad8d27c394d1ec8b182f385239

>   giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 5234730106949676732ae5ce4428ff8c65d023dd

>   giraph-examples/src/test/java/org/apache/giraph/TestManualCheckpoint.java eb2338c2dbafb2efdc2707f7fc323a26fcb3ea8f

>   giraph-examples/src/test/java/org/apache/giraph/TestPartitionContext.java 41f5e3c841a89f5c5d500a414f6fc4ae804b8705

>   giraph-examples/src/test/java/org/apache/giraph/aggregators/TestAggregatorsHandling.java
7deeb42a71a884b1d62f2b6bcac04d2dd61960db 
>   giraph-examples/src/test/java/org/apache/giraph/examples/TestPageRank.java f56d7e5f4e845ef685a4eaadbdad528e60f3e8a4

>   giraph-examples/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPortsTest.java
c5d3a552ace96a4378e2181c8bdd2d871e487692 
>   giraph-examples/src/test/java/org/apache/giraph/vertex/TestVertexTypes.java 5ca55b6e5ab84fafc6129590238fbbee37b3185d

> 
> Diff: https://reviews.apache.org/r/10156/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message