giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo" <majakabi...@fb.com>
Subject Re: Review Request: Auto-set Hive reusing objects options
Date Wed, 27 Mar 2013 21:58:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10148/#review18442
-----------------------------------------------------------



giraph-core/src/main/java/org/apache/giraph/partition/ReusesObjectsPartition.java
<https://reviews.apache.org/r/10148/#comment38663>

    Make ByteArrayPartition implement this interface



giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java
<https://reviews.apache.org/r/10148/#comment38662>

    You don't need this, we can always reuse edge objects in edge input. But for vertex input
(currently HiveToVertexEdges) we want to have this infromation, right?


- Maja Kabiljo


On March 27, 2013, 7:12 a.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10148/
> -----------------------------------------------------------
> 
> (Updated March 27, 2013, 7:12 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/GIRAPH-594
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java c13f3a268edc0d514314d8813ce0e59dd4ed056f

>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java ffcae6e79cf0bd96745ef9bc9fc420f5b28494b2

>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
de85ab63306b63145159cfaf3d587fcef8ae58ce 
>   giraph-core/src/main/java/org/apache/giraph/partition/ReusesObjectsPartition.java PRE-CREATION

>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java efc08d30d0832f25c5805531562b133a3f9d6cf1

> 
> Diff: https://reviews.apache.org/r/10148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message