giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta" <alessan...@fb.com>
Subject Re: Review Request: GIRAPH-579
Date Tue, 26 Mar 2013 21:46:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10092/
-----------------------------------------------------------

(Updated March 26, 2013, 9:46 p.m.)


Review request for giraph.


Changes
-------

Changed the comments to make it clear that this affects edge-based input (as suggested by
Maja).


Summary (updated)
-----------------

GIRAPH-579


Description
-------

Introduces an option to specify a different VertexEdges class to be used during edge input.
EdgeStore#moveEdgesToVertices() is now multithreaded (it uses the same number of threads as
used for reading input).


This addresses bug GIRAPH-579.
    https://issues.apache.org/jira/browse/GIRAPH-579


Diffs (updated)
-----

  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java d67d3a58156961554cba4af820e017c1942017d4

  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 3b84831107a1c97e81238b2eed6184a036164072

  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 42f8abc170f3cf439cc38377a00df030b60ad08f

  giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
2a3466d8b7dfee803598b027a31fae6b631024ed 
  giraph-core/src/main/java/org/apache/giraph/edge/EdgeStore.java 234c267661ed884eea1746d0d89056b6d310c88e

  giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java eace06f2ea92e009672d6ee145a3ebb379f980a1

  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java cb2a2f70ec6e6127baf90c61953645446c1f10b3

  giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java abf69501fbb08c514610b933c4c97ea51a983ace

  giraph-core/src/test/java/org/apache/giraph/io/TestEdgeInput.java bfc7e8b6541a58ea53bfd10f3a53687fa21ff1b1


Diff: https://reviews.apache.org/r/10092/diff/


Testing
-------

1) mvn verify
2) tested at scale both the case where the input edges data structure is the same or a different
one


Thanks,

Alessandro Presta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message