giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta" <alessan...@fb.com>
Subject Re: Review Request: Fix log messages produced by aggregators
Date Wed, 20 Mar 2013 18:24:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10029/#review18167
-----------------------------------------------------------


Looks good, +1.

- Alessandro Presta


On March 20, 2013, 3:29 a.m., Maja Kabiljo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10029/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 3:29 a.m.)
> 
> 
> Review request for giraph and Alessandro Presta.
> 
> 
> Description
> -------
> 
> Now we'll be writing which workers are we waiting for.
> 
> 
> This addresses bug GIRAPH-537.
>     https://issues.apache.org/jira/browse/GIRAPH-537
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/comm/aggregators/AllAggregatorServerData.java
dddd1cb 
>   giraph-core/src/main/java/org/apache/giraph/comm/aggregators/OwnerAggregatorServerData.java
70ff7fe 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyMasterClient.java 86ea8dc

>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerAggregatorRequestProcessor.java
cd24219 
>   giraph-core/src/main/java/org/apache/giraph/comm/requests/ByteArrayWithSenderTaskIdRequest.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/comm/requests/SendAggregatorsToOwnerRequest.java
21b1b2d 
>   giraph-core/src/main/java/org/apache/giraph/comm/requests/SendAggregatorsToWorkerRequest.java
7e84e17 
>   giraph-core/src/main/java/org/apache/giraph/comm/requests/SendWorkerAggregatorsRequest.java
264f03a 
>   giraph-core/src/main/java/org/apache/giraph/utils/ExpectedBarrier.java ccd137c 
>   giraph-core/src/main/java/org/apache/giraph/utils/TaskIdsPermitsBarrier.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/worker/WorkerAggregatorHandler.java 001cf59

> 
> Diff: https://reviews.apache.org/r/10029/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> AggregatorsBenchmark
> 
> 
> Thanks,
> 
> Maja Kabiljo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message