giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Schelter" <...@apache.org>
Subject Re: Review Request: GIRAPH-480: Add convergence detection to org.apache.giraph.examples.RandomWalkVertex
Date Tue, 19 Mar 2013 08:03:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9850/
-----------------------------------------------------------

(Updated March 19, 2013, 8:03 a.m.)


Review request for giraph.


Changes
-------

Reworked the patch to match Alessandro's comments


Description
-------

Added convergence detection to the RandomWalkVertex, added a PageRank implementation based
on the RandomWalkVertex, refactored the RandomWalkVertex to be indepedent of the edge type
(PageRank with uniform transition probabilities doesn't need edge weights for example)


Diffs (updated)
-----

  giraph-examples/pom.xml 7a18711 
  giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleNullDoubleTextInputFormat.java
PRE-CREATION 
  giraph-examples/src/main/java/org/apache/giraph/examples/PageRankVertex.java PRE-CREATION

  giraph-examples/src/main/java/org/apache/giraph/examples/RandomWalkVertex.java 8196523 
  giraph-examples/src/main/java/org/apache/giraph/examples/RandomWalkWithRestartVertex.java
8a689ed 
  giraph-examples/src/main/java/org/apache/giraph/examples/RandomWalkWorkerContext.java 5cff23f

  giraph-examples/src/main/java/org/apache/giraph/examples/VertexWithDoubleValueNullEdgeTextOutputFormat.java
PRE-CREATION 
  giraph-examples/src/test/java/org/apache/giraph/examples/PageRankVertexTest.java PRE-CREATION

  giraph-examples/src/test/java/org/apache/giraph/examples/RandomWalkTestUtils.java PRE-CREATION

  giraph-examples/src/test/java/org/apache/giraph/examples/RandomWalkWithRestartVertexTest.java
489b35a 

Diff: https://reviews.apache.org/r/9850/diff/


Testing
-------

Ran the junit tests locally


Thanks,

Sebastian Schelter


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message