Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 104D4E58A for ; Tue, 5 Feb 2013 19:04:14 +0000 (UTC) Received: (qmail 5490 invoked by uid 500); 5 Feb 2013 19:04:12 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 5438 invoked by uid 500); 5 Feb 2013 19:04:12 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 5396 invoked by uid 500); 5 Feb 2013 19:04:12 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Received: (qmail 5383 invoked by uid 99); 5 Feb 2013 19:04:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Feb 2013 19:04:12 +0000 Date: Tue, 5 Feb 2013 19:04:12 +0000 (UTC) From: "Nitay Joffe (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (GIRAPH-493) Remove EdgeWithSource MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GIRAPH-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated GIRAPH-493: ------------------------------- Attachment: GIRAPH-493-2.patch Updated patch. > Remove EdgeWithSource > --------------------- > > Key: GIRAPH-493 > URL: https://issues.apache.org/jira/browse/GIRAPH-493 > Project: Giraph > Issue Type: Bug > Reporter: Nitay Joffe > Assignee: Nitay Joffe > Attachments: GIRAPH-493-2.patch, GIRAPH-493.patch > > > We create a lot of EdgeWithSource (one per edge read) only to grab the sourceID / Edge out of them right after. Since we are not actually keeping these objects around we might as well just make the interface getSourceId() and getEdge() instead of the current get edge with source, and save on creating all of these objects. > https://reviews.apache.org/r/9162/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira