Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E79AFE335 for ; Fri, 8 Feb 2013 10:57:27 +0000 (UTC) Received: (qmail 49369 invoked by uid 500); 8 Feb 2013 10:57:27 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 49190 invoked by uid 500); 8 Feb 2013 10:57:27 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 49167 invoked by uid 99); 8 Feb 2013 10:57:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Feb 2013 10:57:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 703F11C5B28; Fri, 8 Feb 2013 10:57:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1719246139129493425==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-504: Create PartitionContext From: "Claudio Martella" To: "Maja Kabiljo" , "giraph" , "Claudio Martella" Date: Fri, 08 Feb 2013 10:57:18 -0000 Message-ID: <20130208105718.13218.334@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Claudio Martella" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/9372/ X-Sender: "Claudio Martella" References: <20130208015729.13216.89395@reviews.apache.org> In-Reply-To: <20130208015729.13216.89395@reviews.apache.org> Reply-To: "Claudio Martella" --===============1719246139129493425== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9372/#review16347 ----------------------------------------------------------- giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java not sure why you set it again here. - Claudio Martella On Feb. 8, 2013, 1:57 a.m., Maja Kabiljo wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9372/ > ----------------------------------------------------------- > = > (Updated Feb. 8, 2013, 1:57 a.m.) > = > = > Review request for giraph. > = > = > Description > ------- > = > Create PartitionContext as a thread-safe place in which to keep data vert= ices share, and do global computation. > = > = > This addresses bug GIRAPH-504. > https://issues.apache.org/jira/browse/GIRAPH-504 > = > = > Diffs > ----- > = > giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java d26= 41f1 = > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.ja= va 9ca1e7e = > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java f= b4e8a3 = > giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraph= Configuration.java 30a7da7 = > giraph-core/src/main/java/org/apache/giraph/examples/PartitionContextTe= stVertex.java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java = 94ed6d9 = > giraph-core/src/main/java/org/apache/giraph/graph/GraphState.java 9cdec= 7c = > giraph-core/src/main/java/org/apache/giraph/partition/BasicPartition.ja= va PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/partition/ByteArrayPartitio= n.java d34af11 = > giraph-core/src/main/java/org/apache/giraph/partition/DefaultPartitionC= ontext.java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/partition/Partition.java 55= ce8c0 = > giraph-core/src/main/java/org/apache/giraph/partition/PartitionContext.= java PRE-CREATION = > giraph-core/src/main/java/org/apache/giraph/partition/SimplePartition.j= ava 479011f = > giraph-core/src/main/java/org/apache/giraph/vertex/Vertex.java 974232e = > giraph-core/src/test/java/org/apache/giraph/BspCase.java 6aab533 = > giraph-core/src/test/java/org/apache/giraph/TestPartitionContext.java P= RE-CREATION = > = > Diff: https://reviews.apache.org/r/9372/diff/ > = > = > Testing > ------- > = > Added test for PartitionContext > mvn clean verify > = > = > Thanks, > = > Maja Kabiljo > = > --===============1719246139129493425==--