giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-530) GiraphInputFormat#getSplits() should be aware of multithreaded input
Date Mon, 25 Feb 2013 17:54:14 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586040#comment-13586040
] 

Alessandro Presta commented on GIRAPH-530:
------------------------------------------

Thanks Maja.
Removed javadoc from all overrides of getSplits(). Will commit soon if there are no further
comments.
                
> GiraphInputFormat#getSplits() should be aware of multithreaded input
> --------------------------------------------------------------------
>
>                 Key: GIRAPH-530
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-530
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>         Attachments: GIRAPH-530.patch, GIRAPH-530.patch
>
>
> The current signature of getSplits() assumes that the only piece of information needed
in order to determine the number of splits is the number of workers.
> With multiple input threads for each worker, this is no longer the case.
> We could solve this very simply by renaming the numWorkers parameter to something like
minSplitCountHint, and changing any existing callers to pass the total number of input threads
instead of workers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message