giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-503) Refactor platform-independent CLI argument parsing in GiraphRunner into a separate class
Date Fri, 08 Feb 2013 17:59:13 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574666#comment-13574666
] 

Eli Reisman commented on GIRAPH-503:
------------------------------------

One thing to realize here too is I really like the idea of a single Runner and customized
Job implementations, and the only reason I am thinking YarnRunner/YarnJob classes at present
rather than a consolidated GiraphRunner is to avoid using munging in the Giraph on YARN code.
All the YARN stuff that effects us happens at the beginning of the job run, so the code I
will be replacing/effecting will be things before GiraphTaskManager in the chain of events.
All the rest will be new stuff.

Anyway, if there's a good way to avoid all the extra Runner or Job classes and munging I'm
all for it, and we can implement it in a future JIRA. Where this one (hopefully) leaves us
is in a place where its easy to implement a runner, input custom args, parse them, check the
ones the "general" parser doesn't check on the returned CommandLine object, then build your
job and go. The GiraphRunner we leave behind after this patch is way, way shorter and clearer.

                
> Refactor platform-independent CLI argument parsing in GiraphRunner into a separate class
> ----------------------------------------------------------------------------------------
>
>                 Key: GIRAPH-503
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-503
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Eli Reisman
>            Assignee: Eli Reisman
>            Priority: Minor
>         Attachments: GIRAPH-503-1.patch, GIRAPH-503-2.patch, GIRAPH-503-3.patch, GIRAPH-503-4.patch,
GIRAPH-503-5.patch
>
>
> In order to run on non Hadoop MR platforms, we will need to populate the GiraphConfiguration
for our job in a platform-independent way so that all config options are available to whatever
driver class initiates the Giraph job (not just GiraphRunner/GiraphJob.) This also serves
to clean up GiraphRunner in general.
> Passes 'mvn clean install'
> Review Board URL: https://reviews.apache.org/r/9350/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message