giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-500) Refactor job launch code out of graph package and into job package
Date Tue, 05 Feb 2013 18:02:12 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571516#comment-13571516
] 

Nitay Joffe commented on GIRAPH-500:
------------------------------------

+1 always a fan of good refactoring
                
> Refactor job launch code out of graph package and into job package
> ------------------------------------------------------------------
>
>                 Key: GIRAPH-500
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-500
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Eli Reisman
>            Assignee: Eli Reisman
>            Priority: Minor
>         Attachments: GIRAPH-500-1.patch
>
>
> There's too many classes in graph and its become a catch-all for all sorts of stuff again.
I'm moving the 4 classes that relate to job launch into a new "org.apache.giraph.job" package.
I left GiraphTaskManager in graph since it is the beginning (nowadays) of the real BSP/Giraph-only
activity that does not relate to how we got to that point (Hadoop mappers running, YARN resource
request, whatever) in the job run. All the preliminary stuff can live in o.a.g.job now. 
> I also left GiraphRunner on the top-level of the source tree since it is easy for new
folks to find there and this way we don't break anyone's existing command lines. We can move
it in a future JIRA, or not at all.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message