giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gustavo Salazar Torres (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-467) Cleanup BspService#process
Date Tue, 12 Feb 2013 22:19:12 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577100#comment-13577100
] 

Gustavo Salazar Torres commented on GIRAPH-467:
-----------------------------------------------

I see there are many if...else's checking for conditions before signaling BspEvent's signal
method. I was thinking to create a BspEventTrigger interface with an evaluate method. EventTrigger
classes would hold a BspEvent instance and "evaluate" method would decide whether to call
or not BspEvent's signal method.
BspService would hold an array of BspEventTrigger instances like you suggested but if some
trigger returns "true" on "evaluate" method then it will stop calling any other.
What do you think?
                
> Cleanup BspService#process
> --------------------------
>
>                 Key: GIRAPH-467
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-467
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>
> lots of duplication, use a vector of events or something

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message