giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitay Joffe" <ni...@apache.org>
Subject Re: Review Request: Refactor CLI arg parsing out of GiraphRunner
Date Fri, 15 Feb 2013 16:52:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9350/#review16651
-----------------------------------------------------------


Sorry for delay. This looks good to me overall. Can you look at  giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HiveGiraphRunner.java
to make sure it jives with these changes?

- Nitay Joffe


On Feb. 12, 2013, 8:20 p.m., Eli Reisman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9350/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2013, 8:20 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> Refactor CLI parsing of args and the assembly of the GiraphConfiguration into its own
class so that other future Runner classes besides GiraphRunner can use it w/o duplication.
You get the idea.
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/GiraphRunner.java 1516fff 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 8797c0e 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/GiraphFileInputFormat.java 9c160fe

>   giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/job/GiraphJob.java 9f711da 
>   giraph-core/src/main/java/org/apache/giraph/job/GiraphTypeValidator.java de2a66d 
>   giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java ae8ebf3

>   giraph-core/src/test/java/org/apache/giraph/io/TestJsonBase64Format.java e2f6fd3 
>   giraph-examples/src/test/java/org/apache/giraph/vertex/TestVertexTypes.java 80187ef

> 
> Diff: https://reviews.apache.org/r/9350/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eli Reisman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message