giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman" <>
Subject Re: Review Request: Refactor CLI arg parsing out of GiraphRunner
Date Fri, 08 Feb 2013 01:04:56 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 8, 2013, 1:04 a.m.)

Review request for giraph.


Sorry about the patch spam. Looking at the RB diff, I forgot to remove something I'm adding
to another JIRA. Otherwise, we're good to go on this. Thanks!


Refactor CLI parsing of args and the assembly of the GiraphConfiguration into its own class
so that other future Runner classes besides GiraphRunner can use it w/o duplication. You get
the idea.

Diffs (updated)

  giraph-core/src/main/java/org/apache/giraph/ b6a6113 
  giraph-core/src/main/java/org/apache/giraph/job/ de2a66d 
  giraph-core/src/main/java/org/apache/giraph/utils/ PRE-CREATION 




Eli Reisman

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message