giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman" <>
Subject Re: Review Request: Refactor CLI arg parsing out of GiraphRunner
Date Fri, 08 Feb 2013 00:48:03 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 8, 2013, 12:48 a.m.)

Review request for giraph.


More babble on the real JIRA for this GIRAPH-503. This is better, and fixes almost all the
issues brought up in the review. Thanks again guys!


Refactor CLI parsing of args and the assembly of the GiraphConfiguration into its own class
so that other future Runner classes besides GiraphRunner can use it w/o duplication. You get
the idea.

Diffs (updated)

  giraph-core/src/main/java/org/apache/giraph/ b6a6113 
  giraph-core/src/main/java/org/apache/giraph/conf/ fb4e8a3 
  giraph-core/src/main/java/org/apache/giraph/job/ de2a66d 
  giraph-core/src/main/java/org/apache/giraph/utils/ PRE-CREATION 




Eli Reisman

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message