giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta" <alessan...@fb.com>
Subject Re: Review Request: GIRAPH-505: Metrics Updates (nitay)
Date Wed, 06 Feb 2013 23:56:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9341/#review16223
-----------------------------------------------------------


Looks good to me, some minor nits.
Thanks in particular for fixing the worker status during multithreaded input.
+1


giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java
<https://reviews.apache.org/r/9341/#comment34669>

    I know it's verbose, but "superstepRequestCounters" sounds more explicit.



giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallable.java
<https://reviews.apache.org/r/9341/#comment34674>

    Same here.



giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallable.java
<https://reviews.apache.org/r/9341/#comment34672>

    Can you specify that the unit is vertices here?



giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallable.java
<https://reviews.apache.org/r/9341/#comment34673>

    This comment should read "every UPDATE_PERIOD vertices read"


- Alessandro Presta


On Feb. 6, 2013, 11:04 p.m., Nitay Joffe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9341/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 11:04 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/GIRAPH-505
> 
> 
> This addresses bug GIRAPH-505.
>     https://issues.apache.org/jira/browse/GIRAPH-505
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/comm/netty/ByteCounter.java 825e3833600b2ec77a821fba52e5a89bcd240d4f

>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java 9e6ed66c226283d2b1e2e27380bfbd3196b5dfcf

>   giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
2a4ee8dad83d40840213a85407e0a95a1dd08762 
>   giraph-core/src/main/java/org/apache/giraph/comm/requests/SendPartitionMutationsRequest.java
22e4944dd049cc2d10518efaa3706f267627e732 
>   giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java a87561df0ad6cfa3190d655c22e01d273c4182e3

>   giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java f7fb7e941cf04ec6f343eefd36929511c710e734

>   giraph-core/src/main/java/org/apache/giraph/metrics/GiraphMetricsRegistry.java 184c97e5d5b96fcdcd3d63f7792add4272ed0c5a

>   giraph-core/src/main/java/org/apache/giraph/metrics/MeterDesc.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/metrics/MetricNames.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/metrics/SuperstepMetricsRegistry.java 71aad3187bca29d05c91ebd516a9b6fa844b09a5

>   giraph-core/src/main/java/org/apache/giraph/metrics/WorkerSuperstepMetrics.java 90567e46a6195acb00e04a2850006762e2ed0ccc

>   giraph-core/src/main/java/org/apache/giraph/utils/MemoryUtils.java eec8388de539a8ac2bd6bde967fb696ee93fd2fa

>   giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallable.java 3e2dc6617a3f07e660815dc10ed149c389985b51

>   giraph-core/src/main/java/org/apache/giraph/worker/InputSplitsCallable.java 5487ab7d99c6e08c22484050ea3bec1a16865c77

>   giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallable.java a192aeb353f0a78131d1cad60a6bfa17e13ceba2

> 
> Diff: https://reviews.apache.org/r/9341/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nitay Joffe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message