Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@giraph.apache.org
Date: Tue, 15 Jan 2013 03:30:12 +0000 (UTC)
From: "Gustavo Salazar Torres (JIRA)" <jira@apache.org>
To: giraph-dev@incubator.apache.org
Message-ID: <JIRA.12603325.1344892177549.135145.1358220612889@arcas>
In-Reply-To: <JIRA.12603325.1344892177549@arcas>
References: <JIRA.12603325.1344892177549@arcas>
Subject: [jira] [Commented] (GIRAPH-299) Constant value in BspServiceMaster
 should be static
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/GIRAPH-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553456#comment-13553456 ] 

Gustavo Salazar Torres commented on GIRAPH-299:
-----------------------------------------------

Sorry, wrong file, attached correct one
                
> Constant value in BspServiceMaster should be static
> ---------------------------------------------------
>
>                 Key: GIRAPH-299
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-299
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.2.0
>            Reporter: Eli Reisman
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-299-2.patch, GIRAPH-299.patch
>
>
> GIRAPH-275 was a victim of this weekend's outage of the JIRA site. When I rebased the patch, I did it from a version that was not the last one I uploaded before said outage. 
> When I rebased the patch today, my most current version was not available to work from. So I forgot to perform the last fix it needed: to take the "localityLimit" constant on line 138 (used on line 536) of BspServiceMaster.java and make it static, and to change the name to LOCALITY_LIMIT to match proper convention.
> For those that already know how to create and upload a patch, please let this wait, its a perfect chance for someone new to submitting patches (and to Giraph) to test drive the process. Thanks!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira