Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@giraph.apache.org
Received-SPF: pass (nike.apache.org: domain of apache.mailbox@gmail.com
 designates 209.85.220.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <JIRA.12603325.1344892177549.156264.1358471111274@arcas>
References: <JIRA.12603325.1344892177549@arcas>
	<JIRA.12603325.1344892177549.156264.1358471111274@arcas>
Date: Fri, 18 Jan 2013 10:32:31 -0800
Message-ID: 
 <CAOsFL5SBFWnQh-7LRXiHys0ST314dM0FdUGn3Fb9ZpxJ4dRufw@mail.gmail.com>
Subject: Re: [jira] [Commented] (GIRAPH-299) Constant value in
 BspServiceMaster should be static
From: Eli Reisman <apache.mailbox@gmail.com>
To: dev@giraph.apache.org
Content-Type: multipart/alternative; boundary=bcaec54fb416a0cc0404d3945527

--bcaec54fb416a0cc0404d3945527
Content-Type: text/plain; charset=ISO-8859-1

I will try it again, but the fail I saw was a test failure rather than
checkstyle. Thanks!

On Thu, Jan 17, 2013 at 5:05 PM, Gustavo Salazar Torres (JIRA) <
jira@apache.org> wrote:

>
>     [
> https://issues.apache.org/jira/browse/GIRAPH-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556835#comment-13556835]
>
> Gustavo Salazar Torres commented on GIRAPH-299:
> -----------------------------------------------
>
> Hi Eli:
> Try the last patch, the problem was a checkstyle rule I was violating.
>
>
> > Constant value in BspServiceMaster should be static
> > ---------------------------------------------------
> >
> >                 Key: GIRAPH-299
> >                 URL: https://issues.apache.org/jira/browse/GIRAPH-299
> >             Project: Giraph
> >          Issue Type: Improvement
> >          Components: graph
> >    Affects Versions: 0.2.0
> >            Reporter: Eli Reisman
> >            Priority: Trivial
> >              Labels: newbie
> >             Fix For: 0.2.0
> >
> >         Attachments: GIRAPH-299-2.patch, GIRAPH-299-3.patch,
> GIRAPH-299.patch
> >
> >
> > GIRAPH-275 was a victim of this weekend's outage of the JIRA site. When
> I rebased the patch, I did it from a version that was not the last one I
> uploaded before said outage.
> > When I rebased the patch today, my most current version was not
> available to work from. So I forgot to perform the last fix it needed: to
> take the "localityLimit" constant on line 138 (used on line 536) of
> BspServiceMaster.java and make it static, and to change the name to
> LOCALITY_LIMIT to match proper convention.
> > For those that already know how to create and upload a patch, please let
> this wait, its a perfect chance for someone new to submitting patches (and
> to Giraph) to test drive the process. Thanks!
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>

--bcaec54fb416a0cc0404d3945527--