Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF96AE412 for ; Tue, 29 Jan 2013 00:04:46 +0000 (UTC) Received: (qmail 37385 invoked by uid 500); 29 Jan 2013 00:04:46 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 37345 invoked by uid 500); 29 Jan 2013 00:04:46 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 37332 invoked by uid 99); 29 Jan 2013 00:04:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Jan 2013 00:04:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EC5101C6D95; Tue, 29 Jan 2013 00:04:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5178134948476363906==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-470: Create Examples Maven project From: "Gustavo Salazar Torres" To: "giraph" , "Nitay Joffe" , "Gustavo Salazar Torres" Date: Tue, 29 Jan 2013 00:04:39 -0000 Message-ID: <20130129000439.24967.89202@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Gustavo Salazar Torres" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/9103/ X-Sender: "Gustavo Salazar Torres" References: <20130124233205.9780.56201@reviews.apache.org> In-Reply-To: <20130124233205.9780.56201@reviews.apache.org> Reply-To: "Gustavo Salazar Torres" --===============5178134948476363906== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9103/ ----------------------------------------------------------- (Updated Jan. 29, 2013, 12:04 a.m.) Review request for giraph. Changes ------- All issues fixed. Description ------- Basically a new maven project was created to hold all the examples package = from the Core project (https://issues.apache.org/jira/browse/GIRAPH-470). = I had to refactor the Algorithm class in Core project because it was locate= d inside examples package. Also all tests related to examples were moved to= the Examples project. Unfortunately some tests that are related to Core ha= d to be moved since they depend on Examples code. A final refactor would be= nice to separate these tests but didn't do it because I considered that wa= s an unrelated task. There is, although, a task related to this problem htt= ps://issues.apache.org/jira/browse/GIRAPH-365. Diffs (updated) ----- giraph-core/pom.xml b0c51b5 = giraph-core/src/main/java/org/apache/giraph/GiraphRunner.java 2e88a83 = giraph-core/src/main/java/org/apache/giraph/examples/AggregatorsTestVerte= x.java c00fda0 = giraph-core/src/main/java/org/apache/giraph/examples/Algorithm.java 57d50= 11 = giraph-core/src/main/java/org/apache/giraph/examples/ConnectedComponentsV= ertex.java b5c90e5 = giraph-core/src/main/java/org/apache/giraph/examples/GeneratedVertexReade= r.java 26f970d = giraph-core/src/main/java/org/apache/giraph/examples/IdentityVertex.java = 7000035 = giraph-core/src/main/java/org/apache/giraph/examples/LongDoubleFloatDoubl= eTextInputFormat.java 53e83a4 = giraph-core/src/main/java/org/apache/giraph/examples/NormalizingLongDoubl= eFloatDoubleTextInputFormat.java 65bc636 = giraph-core/src/main/java/org/apache/giraph/examples/RandomWalkVertex.jav= a 3c0abe7 = giraph-core/src/main/java/org/apache/giraph/examples/RandomWalkWithRestar= tVertex.java 8a689ed = giraph-core/src/main/java/org/apache/giraph/examples/RandomWalkWorkerCont= ext.java 5cff23f = giraph-core/src/main/java/org/apache/giraph/examples/SimpleAggregatorWrit= er.java 1887621 = giraph-core/src/main/java/org/apache/giraph/examples/SimpleCheckpointVert= ex.java b23a163 = giraph-core/src/main/java/org/apache/giraph/examples/SimpleCombinerVertex= .java be0f16c = giraph-core/src/main/java/org/apache/giraph/examples/SimpleFailVertex.jav= a 521ed97 = giraph-core/src/main/java/org/apache/giraph/examples/SimpleInDegreeCountV= ertex.java 605d9d5 = giraph-core/src/main/java/org/apache/giraph/examples/SimpleLongDoubleDoub= leDoubleIdentityVertex.java c7349d1 = giraph-core/src/main/java/org/apache/giraph/examples/SimpleMasterComputeV= ertex.java e481ff7 = giraph-core/src/main/java/org/apache/giraph/examples/SimpleMsgVertex.java= 8016490 = giraph-core/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVer= tex.java 5d7deb7 = giraph-core/src/main/java/org/apache/giraph/examples/SimpleOutDegreeCount= Vertex.java 1e010a1 = giraph-core/src/main/java/org/apache/giraph/examples/SimplePageRankVertex= .java c3b79b4 = giraph-core/src/main/java/org/apache/giraph/examples/SimpleShortestPathsV= ertex.java 1bec7eb = giraph-core/src/main/java/org/apache/giraph/examples/SimpleSuperstepVerte= x.java 2837a57 = giraph-core/src/main/java/org/apache/giraph/examples/SimpleTextVertexOutp= utFormat.java a57c6d2 = giraph-core/src/main/java/org/apache/giraph/examples/SimpleTriangleClosin= gVertex.java 484dd8a = giraph-core/src/main/java/org/apache/giraph/examples/SimpleVertexWithWork= erContext.java b7605bb = giraph-core/src/main/java/org/apache/giraph/examples/VerifyMessage.java 2= 914360 = giraph-core/src/main/java/org/apache/giraph/examples/VertexWithDoubleValu= eFloatEdgeTextOutputFormat.java ef58bb8 = giraph-core/src/main/java/org/apache/giraph/examples/package-info.java 3e= bb72b = giraph-core/src/test/java/org/apache/giraph/BspCase.java f43efe9 = giraph-core/src/test/java/org/apache/giraph/TestAutoCheckpoint.java 87af2= 97 = giraph-core/src/test/java/org/apache/giraph/TestBspBasic.java 987f51c = giraph-core/src/test/java/org/apache/giraph/TestGraphPartitioner.java ff7= 1b86 = giraph-core/src/test/java/org/apache/giraph/TestManualCheckpoint.java 7d3= dde3 = giraph-core/src/test/java/org/apache/giraph/TestMutateGraph.java 7bac9e8 = giraph-core/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java 76= 54305 = giraph-core/src/test/java/org/apache/giraph/aggregators/TestAggregatorsHa= ndling.java 40db41f = giraph-core/src/test/java/org/apache/giraph/examples/ConnectedComponentsV= ertexTest.java 49a2f33 = giraph-core/src/test/java/org/apache/giraph/examples/MinimumIntCombinerTe= st.java 434c756 = giraph-core/src/test/java/org/apache/giraph/examples/RandomWalkWithRestar= tVertexTest.java 4052fe1 = giraph-core/src/test/java/org/apache/giraph/examples/SimpleShortestPathsV= ertexTest.java 8037e9e = giraph-core/src/test/java/org/apache/giraph/examples/SimpleTriangleClosin= gVertexTest.java 6af7339 = giraph-core/src/test/java/org/apache/giraph/examples/TestPageRank.java 39= 09f46 = giraph-core/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPo= rtsTest.java 2f9704d = giraph-core/src/test/java/org/apache/giraph/vertex/TestVertexTypes.java 1= a260d5 = pom.xml 19e7ec8 = Diff: https://reviews.apache.org/r/9103/diff/ Testing ------- All tests passed, at least here in my laptop. Thanks, Gustavo Salazar Torres --===============5178134948476363906==--