giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-493) Remove EdgeWithSource
Date Thu, 31 Jan 2013 18:33:12 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567908#comment-13567908
] 

Alessandro Presta commented on GIRAPH-493:
------------------------------------------

I'm not against the principle of reducing object creation, but I would like to see a change
like this (API-breaking) substantiated with some benchmarks.
                
> Remove EdgeWithSource
> ---------------------
>
>                 Key: GIRAPH-493
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-493
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>         Attachments: GIRAPH-493.patch
>
>
> We create a lot of EdgeWithSource (one per edge read) only to grab the sourceID / Edge
out of them right after. Since we are not actually keeping these objects around we might as
well just make the interface getSourceId() and getEdge() instead of the current get edge with
source, and save on creating all of these objects.
> https://reviews.apache.org/r/9162/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message