giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-469) Cleanup GraphMapper
Date Mon, 28 Jan 2013 22:47:13 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564792#comment-13564792
] 

Hudson commented on GIRAPH-469:
-------------------------------

Integrated in Giraph-trunk-Commit #645 (See [https://builds.apache.org/job/Giraph-trunk-Commit/645/])
    GIRAPH-469: Refactor GraphMapper (ereisman) (Revision 303386f75685e8133c20c213027d4e34ee580bc9)

     Result = SUCCESS
ereisman : http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=303386f75685e8133c20c213027d4e34ee580bc9
Files : 
* giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
* giraph-core/src/main/java/org/apache/giraph/master/MasterCompute.java
* giraph-core/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
* giraph-core/src/main/java/org/apache/giraph/worker/InputSplitsCallable.java
* giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java
* giraph-core/src/main/java/org/apache/giraph/metrics/AggregatedMetrics.java
* giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java
* giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java
* CHANGELOG
* giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java
* giraph-core/src/main/java/org/apache/giraph/metrics/WorkerSuperstepMetrics.java
* giraph-core/src/main/java/org/apache/giraph/vertex/Vertex.java
* giraph-core/src/main/java/org/apache/giraph/graph/GraphMapper.java
* giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java
* giraph-core/src/main/java/org/apache/giraph/graph/GraphState.java

                
> Cleanup GraphMapper
> -------------------
>
>                 Key: GIRAPH-469
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-469
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Assignee: Eli Reisman
>         Attachments: GIRAPH-469-1-eli-idea.patch, GIRAPH-469-2.patch, GIRAPH-469-3.patch,
GIRAPH-469-4.patch, GIRAPH-469-5.patch
>
>
> I don't see why we even call a map() method seeing as we are overriding run(). We are
clearly not particularly "mapreduce-y" so we should make it our entry point more clear than
a map(). Also I think we should have something like a WorkerThread similar to MasterThread
and clean up all of this to just creare whichever threads the node is assigned roles of.
> Link to review board:
> https://reviews.apache.org/r/8898/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message